mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] kill extraneous printk in kernel_restart()
@ 2006-08-18 21:02 Cal Peake
  2006-08-19  3:41 ` Eric W. Biederman
  0 siblings, 1 reply; 2+ messages in thread
From: Cal Peake @ 2006-08-18 21:02 UTC (permalink / raw)
  To: Eric W. Biederman; +Cc: Kernel Mailing List, Andrew Morton

Hi,

Is there a reason for printing a single dot and newline in 
kernel_restart()? If not, below is a one-liner to kill it.

thanks,
  - C.

-- 

Get rid of an extraneous printk in kernel_restart().

Signed-off-by: Cal Peake <cp@absolutedigital.net>

--- linux-2.6.18-rc4/kernel/sys.c~orig	2006-08-07 22:00:27.000000000 -0400
+++ linux-2.6.18-rc4/kernel/sys.c	2006-08-18 16:52:52.000000000 -0400
@@ -611,7 +611,6 @@ void kernel_restart(char *cmd)
 	} else {
 		printk(KERN_EMERG "Restarting system with command '%s'.\n", cmd);
 	}
-	printk(".\n");
 	machine_restart(cmd);
 }
 EXPORT_SYMBOL_GPL(kernel_restart);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] kill extraneous printk in kernel_restart()
  2006-08-18 21:02 [PATCH] kill extraneous printk in kernel_restart() Cal Peake
@ 2006-08-19  3:41 ` Eric W. Biederman
  0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2006-08-19  3:41 UTC (permalink / raw)
  To: Cal Peake; +Cc: Kernel Mailing List, Andrew Morton

Cal Peake <cp@absolutedigital.net> writes:

> Hi,
>
> Is there a reason for printing a single dot and newline in 
> kernel_restart()? If not, below is a one-liner to kill it.

Hmm.  This looks like a thinko from my original patch.

Signed-off-By: Eric W. Biederman <ebiederm@xmission.com>

> -- 
>
> Get rid of an extraneous printk in kernel_restart().
>
> Signed-off-by: Cal Peake <cp@absolutedigital.net>
>
> --- linux-2.6.18-rc4/kernel/sys.c~orig	2006-08-07 22:00:27.000000000 -0400
> +++ linux-2.6.18-rc4/kernel/sys.c	2006-08-18 16:52:52.000000000 -0400
> @@ -611,7 +611,6 @@ void kernel_restart(char *cmd)
>  	} else {
>  		printk(KERN_EMERG "Restarting system with command '%s'.\n", cmd);
>  	}
> -	printk(".\n");
>  	machine_restart(cmd);
>  }
>  EXPORT_SYMBOL_GPL(kernel_restart);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-08-19  3:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-18 21:02 [PATCH] kill extraneous printk in kernel_restart() Cal Peake
2006-08-19  3:41 ` Eric W. Biederman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome