From: ebiederm@xmission.com (Eric W. Biederman)
To: Linus Torvalds <torvalds@osdl.org>
Cc: Pavel Machek <pavel@suse.cz>,
Stephen Hemminger <shemminger@osdl.org>,
ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: kernel/microcode.c error from new 64bit code
Date: 21 Feb 2004 12:30:34 -0700 [thread overview]
Message-ID: <m14qtkkz6t.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0402211102360.3301@ppc970.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
> On Sat, 21 Feb 2004, Eric W. Biederman wrote:
> >
> > What is wrong with the original?
> >
> > - wrmsr(MSR_IA32_UCODE_WRITE, (unsigned int)(uci->mc->bits), 0);
> >
> > I don't see how anything else could be correct.
>
> Did you miss the fact that we now support x86-64, and that if compiled
> that way the address is 64-bit?
No I missed the fact that uci->mc->bits was an address. Now it
makes sense how we can have a 64bit value only in 64bit mode....
The code still feels a little awkward but after looking at it
some more I don't see any problems.
Eric
next prev parent reply other threads:[~2004-02-21 19:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-18 22:52 Stephen Hemminger
2004-02-18 23:08 ` Linus Torvalds
2004-02-18 23:21 ` Linus Torvalds
2004-02-21 14:16 ` Pavel Machek
2004-02-21 17:18 ` Linus Torvalds
2004-02-21 17:34 ` Pavel Machek
2004-02-21 17:44 ` Linus Torvalds
2004-02-21 18:36 ` Eric W. Biederman
2004-02-21 18:48 ` Pavel Machek
2004-02-21 19:03 ` Linus Torvalds
2004-02-21 19:30 ` Eric W. Biederman [this message]
2004-02-22 20:12 ` H. Peter Anvin
2004-02-22 20:32 ` Linus Torvalds
2004-02-22 20:33 ` H. Peter Anvin
2004-02-22 20:41 ` H. Peter Anvin
2004-02-19 0:12 Nakajima, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m14qtkkz6t.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=shemminger@osdl.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®