From: ebiederm@xmission.com (Eric W. Biederman)
To: Linus Torvalds <torvalds@osdl.org>
Cc: Pavel Machek <pavel@suse.cz>,
Stephen Hemminger <shemminger@osdl.org>,
ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: kernel/microcode.c error from new 64bit code
Date: 21 Feb 2004 11:36:14 -0700 [thread overview]
Message-ID: <m18yiwl1pd.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0402210944050.3301@ppc970.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
> On Sat, 21 Feb 2004, Pavel Machek wrote:
> >
> > I'm just afraid that someone will mail you a patch replacing that with
> > >> 32 and you'll overlook it.
>
> Well, the good news is that ">> 32" should cause gcc to complain with a
> big warning (exactly because it's undefined brhaviour on a 32-bit
> architecture), so I don't think it's easy to overlook.
What is wrong with the original?
- wrmsr(MSR_IA32_UCODE_WRITE, (unsigned int)(uci->mc->bits), 0);
I don't see how anything else could be correct.
Either we have high bits we need to worry about in 32bit mode, in which
case the 32bit variant is wrong. Or we don't have high bits to worry
about in which case attempting to set them is wrong.
Eric
next prev parent reply other threads:[~2004-02-21 18:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-18 22:52 Stephen Hemminger
2004-02-18 23:08 ` Linus Torvalds
2004-02-18 23:21 ` Linus Torvalds
2004-02-21 14:16 ` Pavel Machek
2004-02-21 17:18 ` Linus Torvalds
2004-02-21 17:34 ` Pavel Machek
2004-02-21 17:44 ` Linus Torvalds
2004-02-21 18:36 ` Eric W. Biederman [this message]
2004-02-21 18:48 ` Pavel Machek
2004-02-21 19:03 ` Linus Torvalds
2004-02-21 19:30 ` Eric W. Biederman
2004-02-22 20:12 ` H. Peter Anvin
2004-02-22 20:32 ` Linus Torvalds
2004-02-22 20:33 ` H. Peter Anvin
2004-02-22 20:41 ` H. Peter Anvin
2004-02-19 0:12 Nakajima, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m18yiwl1pd.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=shemminger@osdl.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®