From: ebiederm@xmission.com (Eric W. Biederman)
To: Albert Herranz <albert_herranz@yahoo.es>
Cc: vgoyal@in.ibm.com, Andrew Morton <akpm@osdl.org>,
fastboot@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [Fastboot] [PATCH] i386: move apic init in init_IRQs
Date: Fri, 21 Oct 2005 12:01:49 -0600 [thread overview]
Message-ID: <m164rqeoky.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20051021165352.22654.qmail@web25806.mail.ukl.yahoo.com> (Albert Herranz's message of "Fri, 21 Oct 2005 18:53:52 +0200 (CEST)")
Albert Herranz <albert_herranz@yahoo.es> writes:
>> > Should the local_irq_disable() call go away onece
>> local_irq_save() got
>> > introduced.
>>
>> Nope. The irqs need to be disabled. The save just
>> allows this
>> to be called in a context where irqs start out
>> disabled. It is
>> just a save.
>
> local_irq_save() also disables interrupts.
Bah. I was thinking and reading local_save_flags()....
So yes that does make the local_irq_disable redundant.
I still used to seeing:
save_flags();
cli();
...
restore_flags();
Eric
next prev parent reply other threads:[~2005-10-21 18:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-04 15:04 Eric W. Biederman
2005-10-04 15:34 ` Maciej W. Rozycki
2005-10-04 15:48 ` Eric W. Biederman
2005-10-04 17:16 ` Maciej W. Rozycki
2005-10-05 18:30 ` [PATCH] i386 apic: Fix mispelling of APIC Eric W. Biederman
2005-10-21 13:33 ` [Fastboot] [PATCH] i386: move apic init in init_IRQs Vivek Goyal
2005-10-21 14:45 ` Eric W. Biederman
2005-10-21 16:53 ` Albert Herranz
2005-10-21 18:01 ` Eric W. Biederman [this message]
2005-10-22 14:52 ` Vivek Goyal
2005-10-22 15:23 ` Eric W. Biederman
2005-10-24 13:03 ` Vivek Goyal
2005-10-24 15:36 ` Eric W. Biederman
2005-10-25 7:17 ` Eric W. Biederman
2005-10-25 7:47 ` [PATCH] i386 mpparse: Only ignore lapic information we can't store Eric W. Biederman
2005-10-25 9:42 ` Vivek Goyal
2005-10-31 17:04 [Fastboot] [PATCH] i386: move apic init in init_IRQs Protasevich, Natalie
2005-10-31 17:18 ` Zwane Mwaikambo
2005-10-31 17:30 ` Eric W. Biederman
2005-10-31 20:26 ` Zwane Mwaikambo
2005-10-31 18:18 ` Eric W. Biederman
2005-10-31 18:31 Protasevich, Natalie
2005-11-01 7:41 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m164rqeoky.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=albert_herranz@yahoo.es \
--cc=fastboot@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®