From: ebiederm@xmission.com (Eric W. Biederman)
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, fastboot@osdl.org
Subject: Re: [PATCH] i386: move apic init in init_IRQs
Date: Tue, 04 Oct 2005 09:48:01 -0600 [thread overview]
Message-ID: <m1psql707i.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <Pine.LNX.4.61L.0510041628160.10696@blysk.ds.pg.gda.pl> (Maciej W. Rozycki's message of "Tue, 4 Oct 2005 16:34:35 +0100 (BST)")
"Maciej W. Rozycki" <macro@linux-mips.org> writes:
> On Tue, 4 Oct 2005, Eric W. Biederman wrote:
>
>> - if (enable_local_apic < 0)
>> - clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability);
>
> I think this should stay.
lapic_disable() already does this. I am just testing the results.
>> + if (enable_local_apic < 0) {
>> + printk(KERN_INFO "Apic disabled\n");
>
> Capitalisation. ;-)
>
> Otherwise it seems reasonable -- provided it works for you. ;-)
So what should the capitalization be? "APIC disabled\n" ?
Sorry.
Eric
next prev parent reply other threads:[~2005-10-04 15:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-04 15:04 Eric W. Biederman
2005-10-04 15:34 ` Maciej W. Rozycki
2005-10-04 15:48 ` Eric W. Biederman [this message]
2005-10-04 17:16 ` Maciej W. Rozycki
2005-10-05 18:30 ` [PATCH] i386 apic: Fix mispelling of APIC Eric W. Biederman
2005-10-21 13:33 ` [Fastboot] [PATCH] i386: move apic init in init_IRQs Vivek Goyal
2005-10-21 14:45 ` Eric W. Biederman
2005-10-21 16:53 ` Albert Herranz
2005-10-21 18:01 ` Eric W. Biederman
2005-10-22 14:52 ` Vivek Goyal
2005-10-22 15:23 ` Eric W. Biederman
2005-10-24 13:03 ` Vivek Goyal
2005-10-24 15:36 ` Eric W. Biederman
2005-10-25 7:17 ` Eric W. Biederman
2005-10-25 7:47 ` [PATCH] i386 mpparse: Only ignore lapic information we can't store Eric W. Biederman
2005-10-25 9:42 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1psql707i.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=fastboot@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome