From: ebiederm@xmission.com (Eric W. Biederman)
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linux-pci@atrey.karlin.mff.cuni.cz,
Greg Kroah-Hartman <greg@kroah.com>,
"David S. Miller" <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
<linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>,
<daniel.e.wolstenholme@intel.com>
Subject: Re: [PATCH 12/21] MSI: Leave MSI-X masking to the irq chip
Date: Wed, 28 Mar 2007 00:05:00 -0600 [thread overview]
Message-ID: <m17it1sy2b.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070322105341.BC584DDF3E@ozlabs.org> (Michael Ellerman's message of "Thu, 22 Mar 2007 21:51:40 +1100")
Michael Ellerman <michael@ellerman.id.au> writes:
> When freeing an MSI-X in msi_free_irq(), the irq must have already been
> free'd (otherwise we'd hit the BUG_ON), and in the process will have been
> masked or otherwise disabled by the irq chip methods. So there's no
> reason to mask again in the MSI code.
Given the recent discussion about the problems of lazy disable I don't believe
the premise of this patch.
Although I suspect the proper solution is to fix free_irq to call ->mask instead
of disable. If an irq fires in the forest and no one is listening who cares.
After which point this patch would make sense again.
Eric
parent reply other threads:[~2007-03-28 6:05 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20070322105341.BC584DDF3E@ozlabs.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m17it1sy2b.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=daniel.e.wolstenholme@intel.com \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome