* Re: [PATCH 12/21] MSI: Leave MSI-X masking to the irq chip
[not found] <20070322105341.BC584DDF3E@ozlabs.org>
@ 2007-03-28 6:05 ` Eric W. Biederman
0 siblings, 0 replies; only message in thread
From: Eric W. Biederman @ 2007-03-28 6:05 UTC (permalink / raw)
To: Michael Ellerman
Cc: linux-pci, Greg Kroah-Hartman, David S. Miller,
Benjamin Herrenschmidt, linux-kernel, Andrew Morton,
daniel.e.wolstenholme
Michael Ellerman <michael@ellerman.id.au> writes:
> When freeing an MSI-X in msi_free_irq(), the irq must have already been
> free'd (otherwise we'd hit the BUG_ON), and in the process will have been
> masked or otherwise disabled by the irq chip methods. So there's no
> reason to mask again in the MSI code.
Given the recent discussion about the problems of lazy disable I don't believe
the premise of this patch.
Although I suspect the proper solution is to fix free_irq to call ->mask instead
of disable. If an irq fires in the forest and no one is listening who cares.
After which point this patch would make sense again.
Eric
^ permalink raw reply [flat|nested] only message in thread