From: ebiederm@xmission.com (Eric W. Biederman)
To: "Bryan O'Sullivan" <bos@serpentine.com>
Cc: Adrian Bunk <bunk@stusta.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
olson@pathscale.com
Subject: Re: 2.6.19-rc4: known unfixed regressions (v3)
Date: Tue, 07 Nov 2006 10:33:36 -0700 [thread overview]
Message-ID: <m18xinb1qn.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <4550B22C.1060307@serpentine.com> (Bryan O'Sullivan's message of "Tue, 07 Nov 2006 08:19:56 -0800")
"Bryan O'Sullivan" <bos@serpentine.com> writes:
> Eric W. Biederman wrote:
>
>> How comes the driver fixes in the context of my patches?
>
> The fix is simple enough, it's just not as clean as I'd like. I have to pull
> apart the contents of the ht_irq_msg that the new update hook is getting passed,
> in order to get the vector out, so that I can reprogram the offending chip
> register after I've done the config space writes. It's a pretty roundabout way
> to do the job.
Huh? As I read the ipath code I am passing you the value that needs to go
into ipath->int_config and thus into dd->ipath_kregs->kr_interrupt_config.
Sure it is coming as 2 32bit words instead of a one big 64 bit one, but
that is simple to fix.
If your card doesn't pay attention to configuration space access cycles then
there should be no reason to write the value there. If your card does pay
attention to the configuration space access cycles it should be trivial to
make this work.
Please stop getting stuck on your existing hack that only put in the vector
number and didn't put in any of the other interrupt routing information.
If you really need to write to both the config space registers and your
magic shadow copy of the register I can certainly do the config space
writes for you. I just figured it would be more efficient not to.
Eric
next prev parent reply other threads:[~2006-11-07 17:34 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-31 4:27 Linux 2.6.19-rc4 Linus Torvalds
2006-10-31 5:34 ` Andrew Morton
2006-10-31 14:43 ` Jun'ichi Nomura
2006-10-31 16:44 ` Linux 2.6.19-rc4: udev compatibility broken? Mark Lord
2006-10-31 15:55 ` Linux 2.6.19-rc4 Linus Torvalds
2006-10-31 16:14 ` Martin J. Bligh
2006-10-31 16:34 ` Ray Lee
2006-10-31 16:51 ` Dave Jones
2006-10-31 21:26 ` Valdis.Kletnieks
2006-10-31 22:39 ` Al Viro
2006-11-02 16:03 ` Valdis.Kletnieks
2006-10-31 20:53 ` Valdis.Kletnieks
2006-10-31 21:29 ` Al Viro
2006-11-01 6:33 ` Willy Tarreau
2006-11-01 20:26 ` Guennadi Liakhovetski
2006-11-01 21:04 ` Sam Ravnborg
2006-11-02 21:19 ` Guennadi Liakhovetski
2006-10-31 18:33 ` Adrian Bunk
2006-10-31 18:36 ` Martin Bligh
2006-10-31 18:54 ` Adrian Bunk
2006-10-31 18:45 ` Adrian Bunk
2006-10-31 19:26 ` Russell King
2006-10-31 19:39 ` Martin Bligh
2006-10-31 17:02 ` CONFIG_USB_USBNET and mii_* (was Re: Linux 2.6.19-rc4) Athanasius
2006-10-31 17:11 ` Randy Dunlap
2006-10-31 19:56 ` 2.6.19-rc4: known unfixed regressions Adrian Bunk
2006-10-31 20:11 ` Greg KH
2006-11-04 3:15 ` Adrian Bunk
2006-10-31 20:12 ` Arjan van de Ven
2006-10-31 20:21 ` Adrian Bunk
2006-11-02 20:02 ` Rafael J. Wysocki
2006-11-02 20:10 ` Andrew Morton
2006-11-02 21:22 ` Auke Kok
2006-11-02 21:55 ` Alan Cox
2006-11-02 20:54 ` Linus Torvalds
2006-11-02 21:29 ` Greg KH
2006-11-02 21:26 ` Adrian Bunk
2006-11-02 21:40 ` Rafael J. Wysocki
2006-10-31 20:08 ` 2.6.19-rc4: known regressions with patches Adrian Bunk
[not found] ` <20061103024132.GG13381@stusta.de>
2006-11-03 2:56 ` [discuss] Linux 2.6.19-rc4: known unfixed regressions (v2) Dave Jones
2006-11-03 8:25 ` Alexey Starikovskiy
2006-11-03 15:56 ` Dave Jones
2006-11-05 17:32 ` Christian
2006-11-05 20:04 ` Dave Jones
2006-11-06 17:35 ` Adrian Bunk
2006-11-06 17:49 ` Dave Jones
2006-11-06 6:00 ` Adrian Bunk
2006-11-06 15:43 ` Christian
2006-11-06 17:20 ` Dave Jones
2006-11-06 17:30 ` Adrian Bunk
2006-11-06 17:37 ` Adrian Bunk
2006-11-04 18:21 ` [linux-usb-devel] " Greg KH
[not found] ` <20061105064801.GV13381@stusta.de>
2006-11-05 13:26 ` 2.6.19-rc4: known unfixed regressions (v3) Michael S. Tsirkin
2006-11-05 13:57 ` Adrian Bunk
2006-11-05 15:17 ` Eric W. Biederman
2006-11-07 4:22 ` Adrian Bunk
2006-11-07 5:18 ` Bryan O'Sullivan
2006-11-07 8:50 ` Eric W. Biederman
2006-11-07 16:19 ` Bryan O'Sullivan
2006-11-07 17:33 ` Eric W. Biederman [this message]
2006-11-07 17:37 ` Dave Olson
2006-11-07 18:20 ` Eric W. Biederman
2006-11-07 20:30 ` Dave Olson
2006-11-07 20:51 ` Eric W. Biederman
2006-11-07 21:01 ` Dave Olson
2006-11-07 21:35 ` Eric W. Biederman
2006-11-07 21:41 ` Dave Olson
2006-11-07 22:25 ` Eric W. Biederman
2006-11-07 18:01 ` Bryan O'Sullivan
2006-11-07 18:29 ` Eric W. Biederman
2006-11-07 21:32 ` Bryan O'Sullivan
2006-11-07 22:00 ` Eric W. Biederman
2006-11-08 5:14 ` Bryan O'Sullivan
2006-11-08 11:11 ` Eric W. Biederman
2006-11-05 15:22 ` Eric W. Biederman
2006-11-06 12:48 ` 2.6.19-rc4: known regressions with patches (v2) Adrian Bunk
2006-11-07 13:30 ` 2.6.19-rc4: known unfixed regressions (v4) Adrian Bunk
[not found] ` <200611070317.42230.earny@net4u.de>
[not found] ` <200611070041.28008.len.brown@intel.com>
[not found] ` <200611072105.50178.earny@net4u.de>
2006-11-08 8:36 ` [linux-pm] 2.6.19-rc4: known unfixed regressions (v3) Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m18xinb1qn.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=bos@serpentine.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=olson@pathscale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome