* [PATCH] reserve 64bit resources on x86_64
@ 2004-08-20 8:36 Eric W. Biederman
0 siblings, 0 replies; only message in thread
From: Eric W. Biederman @ 2004-08-20 8:36 UTC (permalink / raw)
To: Andi Kleen; +Cc: linux-kernel
Andi,
The hack from the i386 kernel to not reserve 64bit resource regions
appears to have made it into x86_64. Since struct resource is 64bit
on 64bit architectures this is completely unnecessary, and dangerous
if the kernel ever assigns a 64bit BAR.
Eric
diff -uNr linux-2.6.8.1-ioapic-virtwire-on-shutdown.x86_64/arch/x86_64/kernel/e820.c linux-2.6.8.1-e820-64bit.x86_64/arch/x86_64/kernel/e820.c
--- linux-2.6.8.1-ioapic-virtwire-on-shutdown.x86_64/arch/x86_64/kernel/e820.c Wed Aug 18 14:54:30 2004
+++ linux-2.6.8.1-e820-64bit.x86_64/arch/x86_64/kernel/e820.c Wed Aug 18 14:59:34 2004
@@ -185,8 +185,6 @@
int i;
for (i = 0; i < e820.nr_map; i++) {
struct resource *res;
- if (e820.map[i].addr + e820.map[i].size > 0x100000000ULL)
- continue;
res = alloc_bootmem_low(sizeof(struct resource));
switch (e820.map[i].type) {
case E820_RAM: res->name = "System RAM"; break;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-08-20 8:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-08-20 8:36 [PATCH] reserve 64bit resources on x86_64 Eric W. Biederman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®