From: ebiederm@xmission.com (Eric W. Biederman)
To: "Yinghai Lu" <yinghai.lu@amd.com>
Cc: "Tobias Diedrich" <ranma+kernel@tdiedrich.de>,
"Linus Torvalds" <torvalds@osdl.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Andi Kleen" <ak@suse.de>, "Andrew Morton" <akpm@osdl.org>
Subject: Re: IO-APIC + timer doesn't work
Date: Tue, 19 Dec 2006 04:27:24 -0700 [thread overview]
Message-ID: <m1ac1kqg6b.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <86802c440612190000k7eb5e68et9c0a776ef85b5177@mail.gmail.com> (Yinghai Lu's message of "Tue, 19 Dec 2006 00:00:27 -0800")
"Yinghai Lu" <yinghai.lu@amd.com> writes:
> On 12/18/06, Eric W. Biederman <ebiederm@xmission.com> wrote:
>> Thanks. The bug is simply that the new code doesn't setup the
>> ioapic for the cases it intends to test. But it does clear out
>> the original programming. So if the normal good case doesn't work the
>> code is going to have problems.
>
> Please check the patch.
Getting there but I don't think we are quite there yet.
One of the issues that this does not address is that currently our probe
order in check_timer is wrong. We should first check what the BIOS
has told us about. And only if that fails should we start guessing,
common configurations.
So the pin2 case should be tested right after the pin1 case as we do
currently. On most new boards that will be a complete noop.
But it is better than our current blind guess at using ExtINT mode.
I figure after we try what the BIOS has told us about and that
has failed we should first try the common irq 0 apic mappings,
and then try the common ExtINT mappings.
The current code causes me to want to scream, it is so silly.
Eric
next prev parent reply other threads:[~2006-12-19 11:28 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 2:06 Linux 2.6.20-rc1 Linus Torvalds
2006-12-14 2:46 ` Gene Heskett
2006-12-14 3:32 ` Linus Torvalds
2006-12-14 5:36 ` Gene Heskett
2006-12-14 17:48 ` ieee1394 in 2.6.20-rc1 (was Re: Linux 2.6.20-rc1) Stefan Richter
2006-12-14 19:08 ` Stefan Richter
2006-12-15 3:17 ` Gene Heskett
2006-12-17 18:11 ` Gene Heskett
2006-12-17 18:31 ` Stefan Richter
2006-12-17 19:04 ` Gene Heskett
2006-12-17 20:21 ` Stefan Richter
2006-12-17 23:34 ` Gene Heskett
2006-12-18 1:05 ` Stefan Richter
2006-12-18 4:29 ` Gene Heskett
2006-12-18 15:45 ` Stefan Richter
2006-12-18 15:54 ` Gene Heskett
2006-12-14 13:59 ` Linux 2.6.20-rc1 Alessandro Suardi
2006-12-14 14:18 ` Steve WIse
2006-12-14 15:48 ` Alan
2006-12-14 19:30 ` Alistair John Strachan
2006-12-14 19:57 ` Linus Torvalds
2006-12-14 20:05 ` Jeff Garzik
2006-12-14 20:26 ` [PATCH] support HDIO_GET_IDENTITY in libata Erik Andersen
2006-12-14 20:31 ` Jeff Garzik
2006-12-14 20:40 ` Erik Andersen
2006-12-16 16:34 ` Jeff Garzik
2006-12-15 18:45 ` Alexey Dobriyan
2006-12-16 16:34 ` Jeff Garzik
2006-12-14 20:16 ` Linux 2.6.20-rc1 Alistair John Strachan
2006-12-14 20:28 ` Jens Axboe
2006-12-14 20:33 ` Jeff Garzik
2006-12-14 20:36 ` Jens Axboe
2006-12-14 20:48 ` Jens Axboe
2006-12-14 21:13 ` Alistair John Strachan
2006-12-14 21:20 ` Jens Axboe
2006-12-15 0:48 ` Alistair John Strachan
2006-12-15 1:41 ` Alistair John Strachan
2006-12-16 21:36 ` Linus Torvalds
2006-12-16 22:28 ` Alistair John Strachan
2006-12-16 22:31 ` Jeff Garzik
2006-12-16 23:00 ` Alistair John Strachan
2006-12-18 18:32 ` Jens Axboe
2006-12-18 18:41 ` Jens Axboe
2006-12-14 21:33 ` Jeff Garzik
2006-12-14 21:44 ` Alistair John Strachan
2006-12-14 21:50 ` Jeff Garzik
2006-12-14 22:33 ` Alistair John Strachan
2006-12-19 12:41 ` Jens Axboe
2006-12-19 14:32 ` Robert Hancock
2006-12-19 14:38 ` Jens Axboe
2006-12-19 14:50 ` Jens Axboe
2006-12-19 17:49 ` Linus Torvalds
2006-12-14 21:53 ` Jeff Garzik
2006-12-14 20:32 ` Nicolas Mailhot
2006-12-14 23:22 ` Jeff Garzik
2006-12-14 23:33 ` Nicolas Mailhot
2006-12-15 16:50 ` Bill Davidsen
2006-12-15 17:28 ` Alan
2006-12-18 21:57 ` Bill Davidsen
[not found] ` <20061216174536.GA2753@melchior.yamamaya.is-a-geek.org>
2006-12-16 18:06 ` IO-APIC + timer doesn't work (was: Linux 2.6.20-rc1) Linus Torvalds
[not found] ` <20061216225338.GA2616@melchior.yamamaya.is-a-geek.org>
[not found] ` <20061216230605.GA2789@melchior.yamamaya.is-a-geek.org>
2006-12-16 23:36 ` Linus Torvalds
[not found] ` <20061216235513.GA2424@melchior.yamamaya.is-a-geek.org>
2006-12-17 0:04 ` IO-APIC + timer doesn't work Linus Torvalds
2006-12-17 5:16 ` Eric W. Biederman
2006-12-17 5:22 ` Eric W. Biederman
2006-12-18 6:16 ` Len Brown
2006-12-17 13:10 ` Tobias Diedrich
2006-12-17 17:26 ` Linus Torvalds
2006-12-17 14:57 ` IO-APIC + timer doesn't work (was: Linux 2.6.20-rc1) Tobias Diedrich
2006-12-18 13:14 ` Eric W. Biederman
2006-12-18 15:23 ` Tobias Diedrich
2006-12-18 15:34 ` Tobias Diedrich
2006-12-18 15:43 ` IO-APIC + timer doesn't work Eric W. Biederman
2006-12-19 8:00 ` Yinghai Lu
2006-12-19 11:27 ` Eric W. Biederman [this message]
2006-12-20 6:50 ` Yinghai Lu
2006-12-21 19:15 ` Tobias Diedrich
2006-12-21 20:46 ` Eric W. Biederman
2006-12-31 8:29 ` Yinghai Lu
2006-12-21 21:24 Lu, Yinghai
2006-12-21 21:40 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ac1kqg6b.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ranma+kernel@tdiedrich.de \
--cc=torvalds@osdl.org \
--cc=yinghai.lu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®