From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysctl: Allow /proc/sys without sys_sysctl
Date: Tue, 11 Jul 2006 00:57:35 -0600 [thread overview]
Message-ID: <m1bqrwiq74.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060710211951.7bf8320b.akpm@osdl.org> (Andrew Morton's message of "Mon, 10 Jul 2006 21:19:51 -0700")
Andrew Morton <akpm@osdl.org> writes:
> On Mon, 10 Jul 2006 16:38:59 -0600
> ebiederm@xmission.com (Eric W. Biederman) wrote:
>
>> Since sys_sysctl is deprecated start allow it to be compiled out.
>
> This could be a tough one to get rid of (looks at sys_bdflush() again).
>
> I'd suggest we put a sys_bdflush()-style warning in there, see what that
> flushes out.
Sounds sane. I know I have booted several kernels with it compiled out
but just because you can do without it doesn't mean that something
isn't using it.
Hmm. The question is where do I want the put the warning message?
When the code is compiled out?
When the code is compiled in?
Probably both places at this point, and using the rate limited printk
I think instead of just the 5 printks that sys_bdflush uses...
I will cook up an incremental patch once I get some sleep.
Eric
next prev parent reply other threads:[~2006-07-11 6:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 22:38 Eric W. Biederman
2006-07-10 22:48 ` Randy.Dunlap
2006-07-11 4:00 ` Eric W. Biederman
2006-07-11 4:19 ` Andrew Morton
2006-07-11 6:57 ` Eric W. Biederman [this message]
2006-07-11 7:04 ` Andrew Morton
2006-07-11 7:52 ` Eric W. Biederman
2006-07-11 8:05 ` Andrew Morton
2006-07-11 7:23 ` [PATCH] sysctl: Scream if someone uses sys_sysctl Eric W. Biederman
2006-07-11 22:26 ` [PATCH] sysctl: Allow /proc/sys without sys_sysctl Andi Kleen
2006-07-12 3:13 ` Eric W. Biederman
2006-07-12 13:32 ` Andi Kleen
2006-07-12 14:47 ` Eric W. Biederman
2006-07-12 14:52 ` Andi Kleen
2006-07-12 15:32 ` Eric W. Biederman
2006-07-12 16:08 ` Andi Kleen
2006-07-12 16:36 ` Eric W. Biederman
2006-07-12 18:24 ` Stephen Hemminger
2006-07-12 19:58 ` Arjan van de Ven
2006-07-13 0:52 ` Theodore Tso
2006-07-14 20:09 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1bqrwiq74.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®