mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] sysctl:  Scream if someone uses sys_sysctl
Date: Tue, 11 Jul 2006 01:23:45 -0600	[thread overview]
Message-ID: <m1lkr0haf2.fsf_-_@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060710211951.7bf8320b.akpm@osdl.org> (Andrew Morton's message of "Mon, 10 Jul 2006 21:19:51 -0700")


As far as I can tell we never use sys_sysctl so I never expect to see
these messages.  But if we do see these it means that there are user
space applications that need to be fixed before we can safely
remove sys_sysctl.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---

Since this patch was trivial I just wipped up this incremental
version.  The code compiles is all I know.

 kernel/sysctl.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 42610e6..6e7f13a 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1306,6 +1306,11 @@ asmlinkage long sys_sysctl(struct __sysc
 	struct __sysctl_args tmp;
 	int error;
 
+	if (printk_ratelimit())
+		printk(KERN_INFO
+			"warning: process `%s' used the obsolete sysctl "
+			"system call\n", current->comm);
+
 	if (copy_from_user(&tmp, args, sizeof(tmp)))
 		return -EFAULT;
 
@@ -2688,6 +2693,10 @@ #else /* CONFIG_SYSCTL_SYSCALL */
 
 asmlinkage long sys_sysctl(struct __sysctl_args __user *args)
 {
+	if (printk_ratelimit())
+		printk(KERN_INFO
+			"warning: process `%s' used the removed sysctl "
+			"system call\n", current->comm);
 	return -ENOSYS;
 }
 
-- 
1.4.1.gac83a


  parent reply	other threads:[~2006-07-11  7:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-10 22:38 [PATCH] sysctl: Allow /proc/sys without sys_sysctl Eric W. Biederman
2006-07-10 22:48 ` Randy.Dunlap
2006-07-11  4:00   ` Eric W. Biederman
2006-07-11  4:19 ` Andrew Morton
2006-07-11  6:57   ` Eric W. Biederman
2006-07-11  7:04     ` Andrew Morton
2006-07-11  7:52       ` Eric W. Biederman
2006-07-11  8:05         ` Andrew Morton
2006-07-11  7:23   ` Eric W. Biederman [this message]
2006-07-11 22:26 ` Andi Kleen
2006-07-12  3:13   ` Eric W. Biederman
2006-07-12 13:32     ` Andi Kleen
2006-07-12 14:47       ` Eric W. Biederman
2006-07-12 14:52         ` Andi Kleen
2006-07-12 15:32           ` Eric W. Biederman
2006-07-12 16:08             ` Andi Kleen
2006-07-12 16:36               ` Eric W. Biederman
2006-07-12 18:24                 ` Stephen Hemminger
2006-07-12 19:58                   ` Arjan van de Ven
2006-07-13  0:52                     ` Theodore Tso
2006-07-14 20:09                       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1lkr0haf2.fsf_-_@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome