mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Linus Torvalds <torvalds@osdl.org>
Cc: Muli Ben-Yehuda <muli@il.ibm.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <ak@muc.de>,
	"Protasevich, Natalie" <Natalie.Protasevich@UNISYS.com>,
	Andrew Morton <akpm@osdl.org>,
	Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/3] i386/x86_64: FIX pci_enable_irq to set dev->irq to the irq number
Date: Sun, 08 Oct 2006 07:41:19 -0600	[thread overview]
Message-ID: <m1fydzudq8.fsf_-_@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <m1k63budt1.fsf_-_@ebiederm.dsl.xmission.com> (Eric W. Biederman's message of "Sun, 08 Oct 2006 07:39:38 -0600")


In commit: ace80ab796ae30d2c9ee8a84ab6f608a61f8b87b  I removed
the weird logic that used the vector number as the irq number
when MSI was defined.  However pci_enable_irq was using a different test
in the io_apic_assign_irqs path and I missed it :(

This patch removes the wrong code so no one hits this problem.

This code is only active when a specific set of boot command line
parameters is specified which likely explains why no one has
notices this earlier.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 arch/i386/pci/irq.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/i386/pci/irq.c b/arch/i386/pci/irq.c
index 47f02af..dbc4aae 100644
--- a/arch/i386/pci/irq.c
+++ b/arch/i386/pci/irq.c
@@ -1141,10 +1141,6 @@ static int pirq_enable_irq(struct pci_de
 			}
 			dev = temp_dev;
 			if (irq >= 0) {
-#ifdef CONFIG_PCI_MSI
-				if (!platform_legacy_irq(irq))
-					irq = IO_APIC_VECTOR(irq);
-#endif
 				printk(KERN_INFO "PCI->APIC IRQ transform: %s[%c] -> IRQ %d\n",
 					pci_name(dev), 'A' + pin, irq);
 				dev->irq = irq;
-- 
1.4.2.rc3.g7e18e-dirty


  reply	other threads:[~2006-10-08 13:43 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-05 21:22 2.6.19-rc1 genirq causes either boot hang or "do_IRQ: cannot handle IRQ -1" Muli Ben-Yehuda
2006-10-06 15:14 ` Eric W. Biederman
2006-10-06 15:50   ` Muli Ben-Yehuda
2006-10-06 16:20     ` Muli Ben-Yehuda
2006-10-06 19:00       ` Andrew Vasquez
2006-10-06 19:42         ` Andrew Morton
2006-10-06 20:02           ` Andrew Vasquez
2006-10-06 20:15             ` Linus Torvalds
2006-10-06 20:18             ` Andrew Morton
2006-10-06 20:42             ` Muli Ben-Yehuda
2006-10-06 20:14           ` Linus Torvalds
2006-10-06 19:53       ` Benjamin LaHaise
2006-10-06 17:47     ` Eric W. Biederman
2006-10-06 20:23       ` Muli Ben-Yehuda
2006-10-06 23:42         ` Eric W. Biederman
2006-10-07  8:03           ` Muli Ben-Yehuda
2006-10-07 16:52             ` Eric W. Biederman
2006-10-07 17:59               ` Muli Ben-Yehuda
2006-10-08 13:39                 ` [PATCH 0/3] x86_64 irq fixes Eric W. Biederman
2006-10-08 13:41                   ` Eric W. Biederman [this message]
2006-10-08 13:43                     ` [PATCH 2/3] i386/x86_64: Remove global IO_APIC_VECTOR Eric W. Biederman
2006-10-08 13:47                       ` [PATCH 3/3] x86_64 irq: Allocate a vector across all cpus for genapic_flat Eric W. Biederman
2006-10-08 19:01                         ` Muli Ben-Yehuda
2006-10-08 18:59                   ` [PATCH 0/3] x86_64 irq fixes Muli Ben-Yehuda
2006-10-07 19:03               ` 2.6.19-rc1 genirq causes either boot hang or "do_IRQ: cannot handle IRQ -1" Linus Torvalds
2006-10-07 19:33                 ` Arjan van de Ven
2006-10-07 19:57                   ` Linus Torvalds
2006-10-09  6:06                     ` Eric W. Biederman
2006-10-09  7:40                       ` Arjan van de Ven
2006-10-09 14:46                         ` Eric W. Biederman
2006-10-09 15:28                           ` Protasevich, Natalie
2006-10-09 15:39                             ` Arjan van de Ven
2006-10-09 16:02                               ` 2.6.19-rc1 genirq causes either boot hang or "do_IRQ: cannothandle " Protasevich, Natalie
2006-10-07 20:24                 ` 2.6.19-rc1 genirq causes either boot hang or "do_IRQ: cannot handle " Eric W. Biederman
2006-10-06 16:02   ` Linus Torvalds
2006-10-06 17:22     ` Eric W. Biederman
2006-10-06 18:08       ` Linus Torvalds
2006-10-06 18:48         ` Eric W. Biederman
2006-10-09  5:41         ` [PATCH 1/1] x86_64 irq: Scream but don't die if we receive an unexpected irq Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1fydzudq8.fsf_-_@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=Natalie.Protasevich@UNISYS.com \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=muli@il.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®