* [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS
@ 2006-10-22 16:42 Yinghai Lu
2006-10-22 16:50 ` Muli Ben-Yehuda
2006-10-22 17:55 ` Eric W. Biederman
0 siblings, 2 replies; 6+ messages in thread
From: Yinghai Lu @ 2006-10-22 16:42 UTC (permalink / raw)
To: Eric W. Biederman, Andi Kleen, Muli Ben-Yehuda; +Cc: Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
Using cpu_online_map instead of APIC_ALL_CPUS for flat apic mode, So
__assign_irq_vector can refer correct per_cpu data.
Cc: Muli Ben-Yehuda <muli@il.ibm.com>
Signed-off-by: Yinghai Lu <yinghai.lu@amd.com>
[-- Attachment #2: vector_allocation_domain.diff --]
[-- Type: text/x-patch, Size: 485 bytes --]
diff --git a/arch/x86_64/kernel/genapic_flat.c b/arch/x86_64/kernel/genapic_flat.c
index 7c01db8..490df69 100644
--- a/arch/x86_64/kernel/genapic_flat.c
+++ b/arch/x86_64/kernel/genapic_flat.c
@@ -32,8 +32,7 @@ static cpumask_t flat_vector_allocation_
* deliver interrupts to the wrong hyperthread when only one
* hyperthread was specified in the interrupt desitination.
*/
- cpumask_t domain = { { [0] = APIC_ALL_CPUS, } };
- return domain;
+ return cpu_online_map;
}
/*
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS
2006-10-22 16:42 [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS Yinghai Lu
@ 2006-10-22 16:50 ` Muli Ben-Yehuda
2006-10-22 17:55 ` Eric W. Biederman
1 sibling, 0 replies; 6+ messages in thread
From: Muli Ben-Yehuda @ 2006-10-22 16:50 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Eric W. Biederman, Andi Kleen, Linux Kernel Mailing List
On Sun, Oct 22, 2006 at 09:42:38AM -0700, Yinghai Lu wrote:
> Using cpu_online_map instead of APIC_ALL_CPUS for flat apic mode, So
> __assign_irq_vector can refer correct per_cpu data.
>
> Cc: Muli Ben-Yehuda <muli@il.ibm.com>
> Signed-off-by: Yinghai Lu <yinghai.lu@amd.com>
Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>
Cheers,
Muli
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS
2006-10-22 16:42 [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS Yinghai Lu
2006-10-22 16:50 ` Muli Ben-Yehuda
@ 2006-10-22 17:55 ` Eric W. Biederman
2006-10-22 19:58 ` Yinghai Lu
1 sibling, 1 reply; 6+ messages in thread
From: Eric W. Biederman @ 2006-10-22 17:55 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Andi Kleen, Muli Ben-Yehuda, Linux Kernel Mailing List
"Yinghai Lu" <yinghai.lu@amd.com> writes:
> Using cpu_online_map instead of APIC_ALL_CPUS for flat apic mode, So
> __assign_irq_vector can refer correct per_cpu data.
>
> Cc: Muli Ben-Yehuda <muli@il.ibm.com>
> Signed-off-by: Yinghai Lu <yinghai.lu@amd.com>
Nack. This fixes the symptom not the bug.
More comprehensive patches follow.
Eric
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS
2006-10-22 17:55 ` Eric W. Biederman
@ 2006-10-22 19:58 ` Yinghai Lu
2006-10-23 7:43 ` Muli Ben-Yehuda
0 siblings, 1 reply; 6+ messages in thread
From: Yinghai Lu @ 2006-10-22 19:58 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: Andi Kleen, Muli Ben-Yehuda, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
Muli,
Can you test this one?
YH
On 10/22/06, Eric W. Biederman <ebiederm@xmission.com> wrote:
> "Yinghai Lu" <yinghai.lu@amd.com> writes:
>
> > Using cpu_online_map instead of APIC_ALL_CPUS for flat apic mode, So
> > __assign_irq_vector can refer correct per_cpu data.
> >
> > Cc: Muli Ben-Yehuda <muli@il.ibm.com>
> > Signed-off-by: Yinghai Lu <yinghai.lu@amd.com>
>
> Nack. This fixes the symptom not the bug.
> More comprehensive patches follow.
>
> Eric
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
[-- Attachment #2: io_apic.diff --]
[-- Type: text/x-patch, Size: 446 bytes --]
diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c
index b000017..29cae92 100644
--- a/arch/x86_64/kernel/io_apic.c
+++ b/arch/x86_64/kernel/io_apic.c
@@ -634,7 +634,7 @@ static int __assign_irq_vector(int irq,
int first, new_cpu;
int vector, offset;
- domain = vector_allocation_domain(cpu);
+ cpus_and(domain, vector_allocation_domain(cpu), mask);
first = first_cpu(domain);
vector = pos[first].vector;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS
2006-10-22 19:58 ` Yinghai Lu
@ 2006-10-23 7:43 ` Muli Ben-Yehuda
2006-10-23 8:05 ` yhlu
0 siblings, 1 reply; 6+ messages in thread
From: Muli Ben-Yehuda @ 2006-10-23 7:43 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Eric W. Biederman, Andi Kleen, Linux Kernel Mailing List
On Sun, Oct 22, 2006 at 12:58:57PM -0700, Yinghai Lu wrote:
> Muli,
>
> Can you test this one?
I assume it was superceded by a later patch, please let me know if it
wasn't.
Cheers,
Muli
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS
2006-10-23 7:43 ` Muli Ben-Yehuda
@ 2006-10-23 8:05 ` yhlu
0 siblings, 0 replies; 6+ messages in thread
From: yhlu @ 2006-10-23 8:05 UTC (permalink / raw)
To: Muli Ben-Yehuda; +Cc: Eric W. Biederman, Andi Kleen, Linux Kernel Mailing List
Please test two patchs from eric.
YH
On 10/23/06, Muli Ben-Yehuda <muli@il.ibm.com> wrote:
> On Sun, Oct 22, 2006 at 12:58:57PM -0700, Yinghai Lu wrote:
>
> > Muli,
> >
> > Can you test this one?
>
> I assume it was superceded by a later patch, please let me know if it
> wasn't.
>
> Cheers,
> Muli
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-10-23 8:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-22 16:42 [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS Yinghai Lu
2006-10-22 16:50 ` Muli Ben-Yehuda
2006-10-22 17:55 ` Eric W. Biederman
2006-10-22 19:58 ` Yinghai Lu
2006-10-23 7:43 ` Muli Ben-Yehuda
2006-10-23 8:05 ` yhlu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®