From: ebiederm@xmission.com (Eric W. Biederman)
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vivek Goyal <vgoyal@redhat.com>,
Brayan Arraes <brayan@yack.com.br>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sysrq, kdump: fix regression, revert "simplify sysrq-c handler"
Date: Tue, 21 Jul 2009 15:18:34 -0700 [thread overview]
Message-ID: <m1ocrdn0hx.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <4A65644F.7010309@cn.fujitsu.com> (Lai Jiangshan's message of "Tue\, 21 Jul 2009 14\:46\:39 +0800")
Lai Jiangshan <laijs@cn.fujitsu.com> writes:
> Even I agreed your fix, I don't agreed your naming,
> For your fix, the correct naming should be:
>
> .help_msg = "oops(C)",
> .action_msg = "Trigger an oops"
>
> And document it:
> Sysrq-c always causes an oops by an indirect way. It'll do one of 4 things:
> 1) panic_on_oops=0, it is just kill the current task.
> 2) panic_on_oops=1, but CONFIG_KEXEC=n, just normal panic
> 3) panic_on_oops=1, CONFIG_KEXEC=y, but not enabled, just normal panic
> 4) panic_on_oops=1, CONFIG_KEXEC=y, kdump was enabled, CrashDump.
That sounds like a great way to sort out the understanding.
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Could you turn that into a proper patch?
Eric
next prev parent reply other threads:[~2009-07-21 22:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 12:46 Lai Jiangshan
2009-07-20 19:22 ` Eric W. Biederman
2009-07-20 21:16 ` Neil Horman
2009-07-21 6:46 ` Lai Jiangshan
2009-07-21 22:18 ` Eric W. Biederman [this message]
2009-07-21 6:00 ` Lai Jiangshan
2009-07-21 6:56 ` Eric W. Biederman
2009-07-21 6:49 ` Hidetoshi Seto
2009-07-21 11:08 ` Neil Horman
2009-07-21 12:16 ` Lai Jiangshan
2009-07-22 2:01 ` Hidetoshi Seto
2009-07-22 11:10 ` Neil Horman
2009-07-22 13:42 ` Vivek Goyal
2009-07-22 19:38 ` Neil Horman
2009-07-23 1:10 ` Hidetoshi Seto
2009-07-23 1:09 ` Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ocrdn0hx.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=brayan@yack.com.br \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome