From: ebiederm@xmission.com (Eric W. Biederman)
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "Andi Kleen" <ak@suse.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Greg KH" <gregkh@suse.de>,
"Bjorn Helgaas" <bjorn.helgaas@hp.com>,
"Vivek Goyal" <vgoyal@in.ibm.com>,
"linux kernel mailing list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3]i386: early init pgt for fix virtual addr in head.S
Date: Fri, 01 Jun 2007 13:17:27 -0600 [thread overview]
Message-ID: <m1ps4fzdq0.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <86802c440705202219o21d11023od1018d253364bf5c@mail.gmail.com> (Yinghai Lu's message of "Sun, 20 May 2007 22:19:13 -0700")
"Yinghai Lu" <yhlu.kernel@gmail.com> writes:
> early init pgt for fix virtual addr in head.S, so can use set_fixmap
> before setup_arch.
> otherwise set_fixmap_nocache will not work for i386
>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Hmm. I'm wondering how my signed off by got on this one.
Maybe I did this at some point.
In any case this patch looks wrong (unless I'm completely mistaken)
because it doesn't appear to handle PAE mode.
Which is why I initialized the early page table in C, in my
last round of patches on this subject.
If we don't know the page table format doing this kind of
thing is very difficult.
Eric
next prev parent reply other threads:[~2007-06-01 19:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 5:19 Yinghai Lu
2007-06-01 19:17 ` Eric W. Biederman [this message]
2007-06-01 19:46 ` Yinghai Lu
2007-06-01 20:34 ` Eric W. Biederman
2007-06-01 21:56 ` Yinghai Lu
2007-06-01 22:27 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ps4fzdq0.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@in.ibm.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®