Re: [PATCH 2/3]i386: early init pgt for fix virtual addr in head.S

[ebiederm@xmission.com (Eric W. Biederman)]

"Yinghai Lu" <yhlu.kernel@gmail.com> writes:

> On 6/1/07, Eric W. Biederman <ebiederm@xmission.com> wrote:
>> "Yinghai Lu" <yhlu.kernel@gmail.com> writes:
>>
>> > early init pgt for fix virtual addr in head.S, so can use set_fixmap
>> > before setup_arch.
>> > otherwise set_fixmap_nocache will not work for i386
>> >
>> > Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
>> > Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>>
>> Hmm.  I'm wondering how my signed off by got on this one.
>> Maybe I did this at some point.
>>
>> In any case this patch looks wrong (unless I'm completely mistaken)
>> because it doesn't appear to handle PAE mode.
>>
>> Which is why I initialized the early page table in C, in my
>> last round of patches on this subject.
>>
>> If we don't know the page table format doing this kind of
>> thing is very difficult.
>
> it is from post for your usb debug port patch. so you have updated one for i386?
> and x86_64 is right?

Yes.  I posted it to lkml, and the virtualization list, on the 30th of April.
I thought you had seen that.

I don't mind you picking up the work, I have so many other things to do.
But I did post a working version.

It wasn't merged for 2.6.22 because it was so close to the merge window
and so much other code was already in Andi queue.

If need be I can dig it up again and repost.

Eric