2.6.24-rc1 sysctl table check failed on PowerMac

2.6.24-rc1 sysctl table check failed on PowerMac

[Mikael Pettersson]

Booting 2.6.24-rc1 on my PowerMac the kernel now spits
out a sysctl warning early in the boot sequence:

--- dmesg-2.6.23
+++ dmesg-2.6.24-rc1
...
 IP route cache hash table entries: 32768 (order: 5, 131072 bytes)
 TCP established hash table entries: 131072 (order: 8, 1048576 bytes)
 TCP bind hash table entries: 65536 (order: 6, 262144 bytes)
 TCP: Hash tables configured (established 131072 bind 65536)
 TCP reno registered
+sysctl table check failed: /kernel .1 Writable sysctl directory
 io scheduler noop registered
 io scheduler anticipatory registered (default)
 io scheduler deadline registered

Re: 2.6.24-rc1 sysctl table check failed on PowerMac

[Alexey Dobriyan]

On Sat, Oct 27, 2007 at 07:57:38PM +0200, Mikael Pettersson wrote:
> Booting 2.6.24-rc1 on my PowerMac the kernel now spits
> out a sysctl warning early in the boot sequence:
> 
> --- dmesg-2.6.23
> +++ dmesg-2.6.24-rc1
> ...
>  IP route cache hash table entries: 32768 (order: 5, 131072 bytes)
>  TCP established hash table entries: 131072 (order: 8, 1048576 bytes)
>  TCP bind hash table entries: 65536 (order: 6, 262144 bytes)
>  TCP: Hash tables configured (established 131072 bind 65536)
>  TCP reno registered
> +sysctl table check failed: /kernel .1 Writable sysctl directory

[PATCH] powerpc: fix sysctl whining re kernel.powersave-nap

kernel was marked with 0755. Everywhere else it's 0555.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 arch/powerpc/kernel/idle.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/powerpc/kernel/idle.c
+++ b/arch/powerpc/kernel/idle.c
@@ -122,7 +122,7 @@ static ctl_table powersave_nap_sysctl_root[] = {
 	{
 		.ctl_name	= CTL_KERN,
 		.procname	= "kernel",
-		.mode		= 0755,
+		.mode		= 0555,
 		.child		= powersave_nap_ctl_table,
 	},
 	{}

[PATCH] Dump stack during sysctl registration failure

[Alexey Dobriyan]

On Sat, Oct 27, 2007 at 10:34:53PM +0400,  wrote:
> --- a/arch/powerpc/kernel/idle.c
> +++ b/arch/powerpc/kernel/idle.c
> @@ -122,7 +122,7 @@ static ctl_table powersave_nap_sysctl_root[] = {
>  	{
>  		.ctl_name	= CTL_KERN,
>  		.procname	= "kernel",
> -		.mode		= 0755,
> +		.mode		= 0555,

Speaking of...


[PATCH] Dump stack during sysctl registration failure

Let's make immediately obvious from where sysctl comes from and
messages itself more noticeable.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 kernel/sysctl_check.c |    1 +
 1 file changed, 1 insertion(+)

--- a/kernel/sysctl_check.c
+++ b/kernel/sysctl_check.c
@@ -1432,6 +1432,7 @@ static void set_fail(const char **fail, struct ctl_table *table, const char *str
 		printk(KERN_ERR "sysctl table check failed: ");
 		sysctl_print_path(table);
 		printk(" %s\n", *fail);
+		dump_stack();
 	}
 	*fail = str;
 }

Re: [PATCH] Dump stack during sysctl registration failure

[Eric W. Biederman]

Alexey Dobriyan <adobriyan@gmail.com> writes:

> On Sat, Oct 27, 2007 at 10:34:53PM +0400,  wrote:
>> --- a/arch/powerpc/kernel/idle.c
>> +++ b/arch/powerpc/kernel/idle.c
>> @@ -122,7 +122,7 @@ static ctl_table powersave_nap_sysctl_root[] = {
>>  	{
>>  		.ctl_name	= CTL_KERN,
>>  		.procname	= "kernel",
>> -		.mode		= 0755,
>> +		.mode		= 0555,
>
> Speaking of...
>
>
> [PATCH] Dump stack during sysctl registration failure
>
> Let's make immediately obvious from where sysctl comes from and
> messages itself more noticeable.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>

For ambiguous cases like directories this looks like a serious
help.