From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] proc: Remove the hard coded inode numbers.
Date: Thu, 07 Sep 2006 12:37:32 -0600 [thread overview]
Message-ID: <m1venzploz.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060907110659.373d6f2b.akpm@osdl.org> (Andrew Morton's message of "Thu, 7 Sep 2006 11:06:59 -0700")
Andrew Morton <akpm@osdl.org> writes:
> On Thu, 07 Sep 2006 11:55:59 -0600
> ebiederm@xmission.com (Eric W. Biederman) wrote:
>
>> Hey, thanks for the review.
>>
>> I don't think so but a comment or two might be in order.
>>
>> Calling filldir with the filename is the important part,
>> and the only real error is if filldir fails.
>>
>> The rest of the logic is about populating and querying the
>> dcache so we can find our real inode number, if every reasonable
>> attempt to perform a dcache lookup fails I simply set the inode
>> number to 1 and use that in filldir. It's wrong but at least
>> I report the file is there.
>>
>> If I can find the dentry I lookup the inode and the inode
>> number and file type, and the dput the dentry.
>>
>> If I can't lookup the dentry I attempt to create it.
>> instantiate will return a dentry or NULL if the dentry I preallocate
>> for it is good enough.
>
> I suspected it was something like that.
>
>> Is there something specific you are not seeing?
>
> Code comments explaining this stuff ;)
Sure. Not every looks at how this is done in filesystems like
smbfs, and fat.
When I get a moment I will see if I can cook up a big fat comment.
Eric
next prev parent reply other threads:[~2006-09-07 18:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-06 16:23 [PATCH 1/5] proc: Make the generation of the self symlink table driven Eric W. Biederman
2006-09-06 16:24 ` [PATCH 2/5] proc: Factor out an instantiate method from every lookup method Eric W. Biederman
2006-09-06 16:27 ` [PATCH 3/5] proc: Remove the hard coded inode numbers Eric W. Biederman
2006-09-06 16:28 ` [PATCH 4/5] proc: Merge proc_tid_attr and proc_tgid_attr Eric W. Biederman
2006-09-06 16:31 ` [PATCH 5/5] proc: Use pid_task instead of open coding it Eric W. Biederman
2006-09-07 17:22 ` [PATCH 3/5] proc: Remove the hard coded inode numbers Andrew Morton
2006-09-07 17:55 ` Eric W. Biederman
2006-09-07 18:06 ` Andrew Morton
2006-09-07 18:37 ` Eric W. Biederman [this message]
2006-09-07 17:18 ` [PATCH 2/5] proc: Factor out an instantiate method from every lookup method Andrew Morton
2006-09-07 18:08 ` Eric W. Biederman
2006-09-07 17:15 ` [PATCH 1/5] proc: Make the generation of the self symlink table driven Andrew Morton
2006-09-07 18:04 ` Eric W. Biederman
2006-09-08 7:07 ` Jan Engelhardt
2006-09-08 11:04 ` Eric W. Biederman
2006-09-08 13:08 ` Jan Engelhardt
2006-09-08 13:27 ` Eric W. Biederman
2006-09-08 16:55 ` Jan Engelhardt
2006-09-09 2:34 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1venzploz.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome