From: ebiederm@xmission.com (Eric W. Biederman)
To: "Jan Beulich" <jbeulich@novell.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] constify tables in kernel/sysctl_check.c
Date: Thu, 20 Dec 2007 16:05:28 -0700 [thread overview]
Message-ID: <m1y7bp6k7b.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <476A73A3.76E4.0078.0@novell.com> (Jan Beulich's message of "Thu, 20 Dec 2007 12:52:35 +0000")
"Jan Beulich" <jbeulich@novell.com> writes:
> Remains the question whether it is intended that many, perhaps even
> large, tables are compiled in without ever having a chance to get used,
> i.e. whether there shouldn't #ifdef CONFIG_xxx get added.
The constification looks good. The file should be compiled only when
we have sysctl support. We use those tables when we call
register_sysctl_table. Which we do a lot.
Eric
next parent reply other threads:[~2007-12-20 23:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <476A73A3.76E4.0078.0@novell.com>
2007-12-20 23:05 ` Eric W. Biederman [this message]
2007-12-21 7:47 ` Jan Beulich
2007-12-21 13:33 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1y7bp6k7b.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®