From: ebiederm@xmission.com (Eric W. Biederman)
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: The i386 and x86_64 genirq patches are wrong!
Date: Wed, 14 Jun 2006 11:31:59 -0600 [thread overview]
Message-ID: <m1y7vzzlrk.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060614070353.GA11896@elte.hu> (Ingo Molnar's message of "Wed, 14 Jun 2006 09:03:53 +0200")
Ingo Molnar <mingo@elte.hu> writes:
> here too it's hard for me to give an answer without seeing your specific
> changes (against whatever base is most convenient to you). MSI certainly
> works fine on current -mm. (at least on my box)
Ok. Looking closer. I have found a clear functional bug.
When CONFIG_PCI_MSI is not set.
move_irq expands to move_native_irq.
ack_ioapic_vector
move_native_irq
ack_ioapic_irq
move_irq
move_native_irq
ack_ioapic_quirk_vector
move_native_irq
ack_ioapic_quirk_irq
move_irq
move_native_irq
So we wind up calling move_native_irq twice when MSI is disabled where
before your conversion we only ever called it once. Luckily in
the case where we have the double call vector_to_irq is a noop so
we only migration the same irq twice.
Eric
next prev parent reply other threads:[~2006-06-14 17:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-13 16:34 Eric W. Biederman
2006-06-14 7:03 ` Ingo Molnar
2006-06-14 7:55 ` Eric W. Biederman
2006-06-14 17:31 ` Eric W. Biederman [this message]
2006-06-19 21:41 ` Andrew Morton
2006-06-20 5:13 ` Eric W. Biederman
2006-06-20 22:23 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1y7vzzlrk.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome