From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@osdl.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: The i386 and x86_64 genirq patches are wrong!
Date: Mon, 19 Jun 2006 23:13:58 -0600 [thread overview]
Message-ID: <m1zmg8flyh.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060619144150.51fe627c.akpm@osdl.org> (Andrew Morton's message of "Mon, 19 Jun 2006 14:41:50 -0700")
Andrew Morton <akpm@osdl.org> writes:
> ebiederm@xmission.com (Eric W. Biederman) wrote:
>>
>> Ingo Molnar <mingo@elte.hu> writes:
>>
>> > here too it's hard for me to give an answer without seeing your specific
>> > changes (against whatever base is most convenient to you). MSI certainly
>> > works fine on current -mm. (at least on my box)
>>
>> Ok. Looking closer. I have found a clear functional bug.
>>
>> When CONFIG_PCI_MSI is not set.
>> move_irq expands to move_native_irq.
>>
>> ack_ioapic_vector
>> move_native_irq
>> ack_ioapic_irq
>> move_irq
>> move_native_irq
>>
>> ack_ioapic_quirk_vector
>> move_native_irq
>> ack_ioapic_quirk_irq
>> move_irq
>> move_native_irq
>>
>> So we wind up calling move_native_irq twice when MSI is disabled where
>> before your conversion we only ever called it once. Luckily in
>> the case where we have the double call vector_to_irq is a noop so
>> we only migration the same irq twice.
>>
>
> OK, but this doesn't seem to answer Ingo's request "could you please send
> that fix to me, against whatever base you have it tested on, and i'll merge
> it to genirq/irqchips [and fix up genirq if needed]. Please also include a
> description of the problem. How common is that edge retrigger problem, and
> how come this has never been seen in the past years since we had
> irqbalance?"
>
> The genirq patches are stuck in limboland until issues like this are
> resolved. I'm not planning on sending them to Linus for 2.6.18 so there's
> no huge rush on it, but it would be nice to get all these loose ends tied
> off reasonably promptly, please.
Should be in the morning. The patches are ready I just need to make certain
I copy all of the appropriate people, add signed-off-by lines, etc.
The reason for the delay was that I didn't have a convenient base. I
had a development effort that as it's final product turned up a bug.
I think everything is in good shape but I don't trust myself until I slept
on it all.
My patches are incremental against 2.6.17-rc6-mm2 as that turned out
to be the easiest place to start.
Eric
next prev parent reply other threads:[~2006-06-20 5:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-13 16:34 Eric W. Biederman
2006-06-14 7:03 ` Ingo Molnar
2006-06-14 7:55 ` Eric W. Biederman
2006-06-14 17:31 ` Eric W. Biederman
2006-06-19 21:41 ` Andrew Morton
2006-06-20 5:13 ` Eric W. Biederman [this message]
2006-06-20 22:23 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1zmg8flyh.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome