From: Chris Ball <cjb@laptop.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-sh@vger.kernel.org, "Greg Kroah-Hartman" <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
Date: Wed, 27 Jul 2011 17:47:01 -0400 [thread overview]
Message-ID: <m2pqkvl7l6.fsf@bob.laptop.org> (raw)
In-Reply-To: <201107262050.23379.rjw@sisk.pl> (Rafael J. Wysocki's message of "Tue, 26 Jul 2011 20:50:23 +0200")
Hi Rafael,
On Tue, Jul 26 2011, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Fix build issue caused by undefined struct scatterlist in
> drivers/mmc/host/tmio_mmc.c.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/mmc/host/tmio_mmc.h | 1 +
> drivers/usb/renesas_usbhs/fifo.c | 1 +
> 2 files changed, 2 insertions(+)
>
> Index: linux-2.6/drivers/mmc/host/tmio_mmc.h
> ===================================================================
> --- linux-2.6.orig/drivers/mmc/host/tmio_mmc.h
> +++ linux-2.6/drivers/mmc/host/tmio_mmc.h
> @@ -21,6 +21,7 @@
> #include <linux/mutex.h>
> #include <linux/pagemap.h>
> #include <linux/spinlock.h>
> +#include <linux/scatterlist.h>
>
> /* Definitions for values the CTRL_SDIO_STATUS register can take. */
> #define TMIO_SDIO_STAT_IOIRQ 0x0001
I'm not able to reproduce the build failure here.
drivers/mmc/host/tmio_mmc.c already performs "#include <linux/scatterlist.h>"
itself (and always has done), so I'm confused about why this is necessary.
Do you have a copy of your build log with the error?
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-07-27 21:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 18:49 [PATCH 0/2] Build fixes related to undefined " Rafael J. Wysocki
2011-07-26 18:50 ` [PATCH 1/2] MMC / TMIO: Fix build issue related to " Rafael J. Wysocki
2011-07-27 20:40 ` Guennadi Liakhovetski
2011-07-27 21:56 ` Rafael J. Wysocki
2011-07-28 20:09 ` Guennadi Liakhovetski
2011-07-28 21:07 ` Rafael J. Wysocki
2011-07-27 21:47 ` Chris Ball [this message]
2011-07-27 22:06 ` Rafael J. Wysocki
2011-07-26 18:51 ` [PATCH 2/2] USB / Renesas: " Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pqkvl7l6.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®