* [PATCH] x86: wrong register was used in align macro
@ 2008-07-30 11:30 Vitaly Mayatskikh
2008-07-30 12:17 ` Vitaly Mayatskikh
0 siblings, 1 reply; 2+ messages in thread
From: Vitaly Mayatskikh @ 2008-07-30 11:30 UTC (permalink / raw)
To: linux-kernel; +Cc: Linus Torvalds
New ALIGN_DESTINATION macro has sad typo: r8d register was used instead
of ecx in fixup section. This can be considered as a regression.
Signed-off-by: Vitaly Mayatskikh <v.mayatskih@gmail.com>
diff --git a/arch/x86/lib/copy_user_64.S b/arch/x86/lib/copy_user_64.S
index dfdf428..f118c11 100644
--- a/arch/x86/lib/copy_user_64.S
+++ b/arch/x86/lib/copy_user_64.S
@@ -52,7 +52,7 @@
jnz 100b
102:
.section .fixup,"ax"
-103: addl %r8d,%edx /* ecx is zerorest also */
+103: addl %ecx,%edx /* ecx is zerorest also */
jmp copy_user_handle_tail
.previous
diff --git a/arch/x86/lib/copy_user_nocache_64.S b/arch/x86/lib/copy_user_nocache_64.S
index 40e0e30..108ad1c 100644
--- a/arch/x86/lib/copy_user_nocache_64.S
+++ b/arch/x86/lib/copy_user_nocache_64.S
@@ -32,7 +32,7 @@
jnz 100b
102:
.section .fixup,"ax"
-103: addl %r8d,%edx /* ecx is zerorest also */
+103: addl %ecx,%edx /* ecx is zerorest also */
jmp copy_user_handle_tail
.previous
--
wbr, Vitaly
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: wrong register was used in align macro
2008-07-30 11:30 [PATCH] x86: wrong register was used in align macro Vitaly Mayatskikh
@ 2008-07-30 12:17 ` Vitaly Mayatskikh
0 siblings, 0 replies; 2+ messages in thread
From: Vitaly Mayatskikh @ 2008-07-30 12:17 UTC (permalink / raw)
To: Vitaly Mayatskikh; +Cc: linux-kernel, Linus Torvalds
Vitaly Mayatskikh <v.mayatskih@gmail.com> writes:
Register ecx was also wrongly loaded with value in r8d in
copy_user_nocache routine.
Signed-off-by: Vitaly Mayatskikh <v.mayatskih@gmail.com>
diff --git a/arch/x86/lib/copy_user_nocache_64.S b/arch/x86/lib/copy_user_nocache_64.S
index 40e0e30..cb0c112 100644
--- a/arch/x86/lib/copy_user_nocache_64.S
+++ b/arch/x86/lib/copy_user_nocache_64.S
@@ -108,7 +108,6 @@ ENTRY(__copy_user_nocache)
jmp 60f
50: movl %ecx,%edx
60: sfence
- movl %r8d,%ecx
jmp copy_user_handle_tail
.previous
--
wbr, Vitaly
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-30 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-30 11:30 [PATCH] x86: wrong register was used in align macro Vitaly Mayatskikh
2008-07-30 12:17 ` Vitaly Mayatskikh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®