drivers/video/aty/radeon_backlight.c

drivers/video/aty/radeon_backlight.c

[James Cloos]

Are there any dependencies in $subject which would preclude changing
drivers/video/Kconfig with:

 config FB_RADEON_BACKLIGHT
         bool "Support for backlight control"
-        depends on FB_RADEON && PMAC_BACKLIGHT
+        depends on FB_RADEON
         select FB_BACKLIGHT
         default y
         help
           Say Y here if you want to control the backlight of your display.

or is radeon_backlight.c only functional when -DCONFIG_PMAC_BACKLIGHT,
even though the pmac routines are all ifdef'ed?

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 1024D/ED7DAEA6

Re: drivers/video/aty/radeon_backlight.c

[Michael Hanselmann]

On Wed, Dec 13, 2006 at 08:46:24AM -0500, James Cloos wrote:
> Are there any dependencies in $subject which would preclude changing
> drivers/video/Kconfig with:

Yes.

> or is radeon_backlight.c only functional when -DCONFIG_PMAC_BACKLIGHT,
> even though the pmac routines are all ifdef'ed?

Did you actually test wether it works? As far as I know, only Apple
(PowerPC) hardware uses these registers yet and have no use anywhere
else.

Greets,
Michael

-- 
Gentoo Linux developer, http://hansmi.ch/, http://forkbomb.ch/

Re: drivers/video/aty/radeon_backlight.c

[James Cloos]

>>>>> "Michael" == Michael Hanselmann <linux-kernel@hansmi.ch> writes:

JimC> Are there any dependencies in $subject which would preclude
JimC> changing drivers/video/Kconfig ....

Michael> Yes.

Ok. Thanks.

JimC> is radeon_backlight.c only functional when -DCONFIG_PMAC_BACKLIGHT,
JimC> even though the pmac routines are all ifdef'ed?

Michael> Did you actually test wether it works? As far as I know,
Michael> only Apple (PowerPC) hardware uses these registers yet
Michael> and have no use anywhere else.

No, I only noticed the file by coincidence and wanted to find out
about it before testing.

Thanks for the quick reply!

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 1024D/ED7DAEA6