From: Krzysztof Halasa <khc@pm.waw.pl>
To: ken@coverity.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [CHECKER] Implementation inconsistencies in 2.6.3
Date: Wed, 28 Apr 2004 18:15:42 +0200 [thread overview]
Message-ID: <m3llkgnknl.fsf@defiant.pm.waw.pl> (raw)
In-Reply-To: <4448.171.64.70.113.1083102442.spork@webmail.coverity.com> (Ken Ashcraft's message of "Tue, 27 Apr 2004 14:47:22 -0700 (PDT)")
"Ken Ashcraft" <ken@coverity.com> writes:
/drivers/net/wan/hdlc_cisco.c:
> ---------------------------------------------------------
> [BUG] <khc@pm.waw.pl> not referencing 'dev'
>
> example:
> /home/kash/linux/2.6.3/linux-2.6.3/drivers/ieee1394/eth1394.c:569:ether1394_header:
> NOTE:READ: Checking arg dev [EXAMPLE=net_device.hard_header-1]
>
> /home/kash/linux/2.6.3/linux-2.6.3/drivers/net/wan/hdlc_cisco.c:37:cisco_hard_header:
> ERROR:READ: Not checking arg [COUNTER=net_device.hard_header-1] [fit=62]
> [fit_fn=1] [fn_ex=0] [fn_counter=1] [ex=10] [counter=1] [z =
> -0.622543017479467] [fn-z = -4.35889894354067]
> #define CISCO_ADDR_REQ 0 /* Cisco address request */
> #define CISCO_ADDR_REPLY 1 /* Cisco address reply */
> #define CISCO_KEEPALIVE_REQ 2 /* Cisco keepalive request */
>
>
>
> Error --->
> static int cisco_hard_header(struct sk_buff *skb, struct net_device *dev,
> u16 type, void *daddr, void *saddr,
> unsigned int len)
> {
False positive - while other hard_header functions may want to know
the actual outbound device, it isn't the case here.
--
Krzysztof Halasa, B*FH
prev parent reply other threads:[~2004-04-28 23:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-27 21:47 Ken Ashcraft
2004-04-27 22:14 ` Matthew Dharm
2004-04-27 22:58 ` Ken Ashcraft
2004-04-27 23:05 ` Matthew Dharm
2004-04-28 0:13 ` Richard B. Johnson
2004-04-28 16:15 ` Krzysztof Halasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3llkgnknl.fsf@defiant.pm.waw.pl \
--to=khc@pm.waw.pl \
--cc=ken@coverity.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®