From: Krzysztof Halasa <khc@pm.waw.pl>
To: "Antonino A. Daplas" <adaplas@pol.net>
Cc: Jean Delvare <khali@linux-fr.org>, Andrew Morton <akpm@osdl.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
Date: Mon, 10 Jul 2006 15:09:32 +0200 [thread overview]
Message-ID: <m3y7v14neb.fsf@defiant.localdomain> (raw)
In-Reply-To: <44B248E4.2020506@pol.net> (Antonino A. Daplas's message of "Mon, 10 Jul 2006 20:32:36 +0800")
"Antonino A. Daplas" <adaplas@pol.net> writes:
>> You're right here, I don't know why I assumed DEPENDS does it
>> automatically.
>
> Use select.
It has a known problem - if the "selected" thing changes (requires
another option etc) things are screwed. With "depends on", you don't
have to track such changes.
While near selects (in the same build directory) are IMHO ok, far
ones are not.
I think it would be different if trying to select something which
can't be selected automatically resulted in a warning. I think
I have to look at it then, but for now I'll use something like
"depends on (FB_CIRRUS=m && I2C && I2C_ALGOBIT) ||
(FB_CIRRUS=y && I2C=y && I2C_ALGOBIT=y)".
--
Krzysztof Halasa
next prev parent reply other threads:[~2006-07-10 13:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200607050147.k651kxmT023763@shell0.pdx.osdl.net>
[not found] ` <20060705165255.ab7f1b83.khali@linux-fr.org>
2006-07-09 20:37 ` Krzysztof Halasa
2006-07-09 23:53 ` Antonino A. Daplas
2006-07-10 9:49 ` Krzysztof Halasa
2006-07-10 10:07 ` Antonino A. Daplas
2006-07-10 10:49 ` Krzysztof Halasa
2006-07-10 11:27 ` Antonino A. Daplas
2006-07-10 11:49 ` Krzysztof Halasa
2006-07-10 12:32 ` Antonino A. Daplas
2006-07-10 13:09 ` Krzysztof Halasa [this message]
2006-07-10 14:29 ` Antonino A. Daplas
2006-07-10 14:46 ` Krzysztof Halasa
2006-07-27 21:23 ` Jean Delvare
2006-07-10 13:27 ` Krzysztof Halasa
2006-07-10 14:11 ` Antonino A. Daplas
2006-07-10 15:37 ` Krzysztof Halasa
2006-07-10 16:30 ` Antonino A. Daplas
2006-07-10 20:34 ` Krzysztof Halasa
2006-07-11 7:22 ` Antonino A. Daplas
2006-07-11 10:53 ` Krzysztof Halasa
2006-07-27 20:55 ` Jean Delvare
2006-07-28 10:05 ` Krzysztof Halasa
2006-07-10 15:18 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y7v14neb.fsf@defiant.localdomain \
--to=khc@pm.waw.pl \
--cc=adaplas@pol.net \
--cc=akpm@osdl.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®