From: Johannes Thumshirn <jthumshirn@suse.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: akpm@linux-foundation.org, JBottomley@Odin.com, kxie@chelsio.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -resend_2 1/1] cxgbi: fix build with EXTRA_CFLAGS
Date: Tue, 06 Oct 2015 14:08:25 +0200 [thread overview]
Message-ID: <mqdmvvwb3nq.fsf@c203.arch.suse.de> (raw)
In-Reply-To: <1444131587-28749-1-git-send-email-jslaby@suse.cz> (Jiri Slaby's message of "Tue, 6 Oct 2015 13:39:47 +0200")
Jiri Slaby <jslaby@suse.cz> writes:
> EXTRA_CFLAGS are intended to be used on the command line, not by
> Kbuild. In case of cxgbi drivers, use of EXTRA_CFLAGS results in a
> compilation failure:
> drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:24:21: fatal error: t4_regs.h: No such file or directory
> when building like:
> $ make drivers/scsi/cxgbi/ EXTRA_CFLAGS=-Wwhatever
>
> Use ccflags-y instead of EXTRA_CFLAGS.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> ---
> Sent on:
> Sep 10
> Jun 9
>
> drivers/scsi/cxgbi/cxgb3i/Kbuild | 2 +-
> drivers/scsi/cxgbi/cxgb4i/Kbuild | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/cxgbi/cxgb3i/Kbuild b/drivers/scsi/cxgbi/cxgb3i/Kbuild
> index 6f095e28a974..961a12f6d318 100644
> --- a/drivers/scsi/cxgbi/cxgb3i/Kbuild
> +++ b/drivers/scsi/cxgbi/cxgb3i/Kbuild
> @@ -1,3 +1,3 @@
> -EXTRA_CFLAGS += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb3
> +ccflags-y += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb3
>
> obj-$(CONFIG_SCSI_CXGB3_ISCSI) += cxgb3i.o
> diff --git a/drivers/scsi/cxgbi/cxgb4i/Kbuild b/drivers/scsi/cxgbi/cxgb4i/Kbuild
> index 8290cdaa4652..37458643749b 100644
> --- a/drivers/scsi/cxgbi/cxgb4i/Kbuild
> +++ b/drivers/scsi/cxgbi/cxgb4i/Kbuild
> @@ -1,3 +1,3 @@
> -EXTRA_CFLAGS += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb4
> +ccflags-y += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb4
>
> obj-$(CONFIG_SCSI_CXGB4_ISCSI) += cxgb4i.o
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
prev parent reply other threads:[~2015-10-06 12:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 11:39 Jiri Slaby
2015-10-06 12:08 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mqdmvvwb3nq.fsf@c203.arch.suse.de \
--to=jthumshirn@suse.de \
--cc=JBottomley@Odin.com \
--cc=akpm@linux-foundation.org \
--cc=jslaby@suse.cz \
--cc=kxie@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®