mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Rishi Gupta <gupt21@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bastien Nocera <bnocera@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: mcp2221: add gpiolib dependency
Date: Wed, 29 Apr 2020 21:47:12 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2004292147030.19713@cbobk.fhfr.pm> (raw)
In-Reply-To: <20200428213035.3108649-1-arnd@arndb.de>

On Tue, 28 Apr 2020, Arnd Bergmann wrote:

> Without gpiolib, this driver fails to link:
> 
> arm-linux-gnueabi-ld: drivers/hid/hid-mcp2221.o: in function `mcp2221_probe':
> hid-mcp2221.c:(.text+0x1b0): undefined reference to `devm_gpiochip_add_data'
> arm-linux-gnueabi-ld: drivers/hid/hid-mcp2221.o: in function `mcp_gpio_get':
> hid-mcp2221.c:(.text+0x30c): undefined reference to `gpiochip_get_data'
> 
> Fixes: 328de1c519c5 ("HID: mcp2221: add GPIO functionality support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks Arnd.

-- 
Jiri Kosina
SUSE Labs


      parent reply	other threads:[~2020-04-29 19:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 21:30 Arnd Bergmann
2020-04-29  3:11 ` rishi gupta
2020-04-29 12:22 ` Linus Walleij
2020-04-29 19:47 ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.2004292147030.19713@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=arnd@arndb.de \
    --cc=benjamin.tissoires@redhat.com \
    --cc=bnocera@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gupt21@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®