From: Jiri Kosina <jikos@kernel.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Peter F . Patel-Schneider" <pfpschneider@gmail.com>,
"Filipe Laíns" <lains@riseup.net>,
"Nestor Lopez Casado" <nlopezcasad@logitech.com>
Subject: Re: [v4 1/5] HID: core: Export hid_match_id()
Date: Wed, 7 Sep 2022 22:09:55 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2209072208490.19850@cbobk.fhfr.pm> (raw)
In-Reply-To: <e907c9240fb2cc0c1e60e3610cfae15ff8125c49.camel@hadess.net>
On Wed, 7 Sep 2022, Bastien Nocera wrote:
> > Export hid_match_id() so it can be used in device-specific drivers to
> > implement their own matching with open-coding a match function.
> >
> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > ---
> > drivers/hid/hid-core.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> > index b7f5566e338d..72f8d8835b34 100644
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -2088,6 +2088,7 @@ const struct hid_device_id *hid_match_id(const
> > struct hid_device *hdev,
> >
> > return NULL;
> > }
> > +EXPORT_SYMBOL_GPL(hid_match_id);
> >
> > static const struct hid_device_id hid_hiddev_list[] = {
> > { HID_USB_DEVICE(USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS) },
>
> If those patches look good to you, would be great to get merged.
> Benjamin doesn't have the bandwidth to test the patches on his own test
> hardware right now, but I've been using them daily for a week now.
Alright, I was waiting for Ack from Benjamin, but based on this, and due
to the fact that I don't see any issue with it myself, I've now applied
the series to for-6.1/logitech branch so that it gets as much linux-next
exposure as possible.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2022-09-07 20:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 13:25 Bastien Nocera
2022-08-30 13:25 ` [v4 2/5] HID: logitech-hidpp: Enable HID++ for all the Logitech Bluetooth devices Bastien Nocera
2022-08-30 13:25 ` [v4 3/5] HID: logitech-hidpp: Remove special-casing of " Bastien Nocera
2022-08-30 13:25 ` [v4 4/5] HID: logitech-hidpp: Fix "Sw. Id." for HID++ 2.0 commands Bastien Nocera
2022-08-30 13:25 ` [v4 5/5] HID: logitech-hidpp: Remove hard-coded " Bastien Nocera
2022-09-07 15:39 ` [v4 1/5] HID: core: Export hid_match_id() Bastien Nocera
2022-09-07 20:09 ` Jiri Kosina [this message]
2022-09-08 8:03 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2209072208490.19850@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=lains@riseup.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nlopezcasad@logitech.com \
--cc=pfpschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®