From: Jonathan Lundell <jlundell@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
tori@unhappy.mine.nu (Tobias Ringstrom)
Cc: ankry@green.mif.pg.gda.pl (Andrzej Krzysztofowicz),
jgarzik@mandrakesoft.com (Jeff Garzik),
akpm@uow.edu.au, alan@lxorguk.ukuu.org.uk (Alan Cox),
linux-kernel@vger.kernel.org (kernel list)
Subject: Re: [PATCH] drivers/net/others
Date: Thu, 24 May 2001 09:00:20 -0700 [thread overview]
Message-ID: <p05100304b732e04cf9aa@[207.213.214.37]> (raw)
In-Reply-To: <E152w81-00053C-00@the-village.bc.nu>
In-Reply-To: <E152w81-00053C-00@the-village.bc.nu>
At 3:30 PM +0100 2001-05-24, Alan Cox wrote:
> > > - printk(version);
>> > + printk("%s", version);
>> >
>> Could you please explain the purpose of this change? To me it looks less
>> efficient in both performance and memory usage.
>
>its called 'programming in C not taking ugly shortcuts'
>>
Fine. But:
At 3:02 AM +0200 2001-05-24, Andrzej Krzysztofowicz wrote:
>- printk(version);
>+#ifdef MODULE
>+ printk("s", version);
> printed_version = 1;
>+#endif /* MODULE */
...is playing it just a little too safe, wouldn't you say?
I assume that MODULE ifdef is related to version being initdata otherwise?
--
/Jonathan Lundell.
next prev parent reply other threads:[~2001-05-24 16:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-24 1:02 Andrzej Krzysztofowicz
2001-05-24 3:43 ` Jeff Garzik
2001-05-24 8:45 ` Tobias Ringstrom
2001-05-24 8:51 ` Lars Marowsky-Bree
2001-05-24 12:01 ` Andrzej Krzysztofowicz
2001-05-24 14:30 ` Alan Cox
2001-05-24 16:00 ` Jonathan Lundell [this message]
2001-05-24 18:22 ` Rasmus Andersen
2001-05-25 9:08 ` Paul Gortmaker
2001-05-25 11:38 ` Andrzej Krzysztofowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='p05100304b732e04cf9aa@[207.213.214.37]' \
--to=jlundell@pobox.com \
--cc=akpm@uow.edu.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ankry@green.mif.pg.gda.pl \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tori@unhappy.mine.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®