[PATCH] re-export genapic on i386

[PATCH] re-export genapic on i386

[Jan Beulich]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

(Note: Patch also attached because the inline version is certain to get
line wrapped.)

A change not too long ago made i386's genapic symbol no longer be
exported,
and thus certain low-level functions no longer be usable. Since
close-to-
the-hardware code may still be modular, this rectifies the situation.

Signed-off-by: Jan Beulich <jbeulich@novell.com>

diff -Npru 2.6.13/arch/i386/mach-generic/probe.c
2.6.13-i386-genapic/arch/i386/mach-generic/probe.c
--- 2.6.13/arch/i386/mach-generic/probe.c	2005-08-29
01:41:01.000000000 +0200
+++ 2.6.13-i386-genapic/arch/i386/mach-generic/probe.c	2005-09-05
14:31:31.000000000 +0200
@@ -3,6 +3,7 @@
  * 
  * Generic x86 APIC driver probe layer.
  */  
+#define APIC_DEFINITION 1
 #include <linux/config.h>
 #include <linux/threads.h>
 #include <linux/cpumask.h>
@@ -10,6 +11,7 @@
 #include <linux/kernel.h>
 #include <linux/ctype.h>
 #include <linux/init.h>
+#include <linux/module.h>
 #include <asm/fixmap.h>
 #include <asm/mpspec.h>
 #include <asm/apicdef.h>
@@ -21,6 +23,7 @@ extern struct genapic apic_es7000;
 extern struct genapic apic_default;
 
 struct genapic *genapic = &apic_default;
+EXPORT_SYMBOL(genapic);
 
 struct genapic *apic_probe[] __initdata = { 
 	&apic_summit,


[-- Attachment #2: linux-2.6.13-i386-genapic.patch --]
[-- Type: application/octet-stream, Size: 1229 bytes --]

(Note: Patch also attached because the inline version is certain to get
line wrapped.)

A change not too long ago made i386's genapic symbol no longer be exported,
and thus certain low-level functions no longer be usable. Since close-to-
the-hardware code may still be modular, this rectifies the situation.

Signed-off-by: Jan Beulich <jbeulich@novell.com>

diff -Npru 2.6.13/arch/i386/mach-generic/probe.c 2.6.13-i386-genapic/arch/i386/mach-generic/probe.c
--- 2.6.13/arch/i386/mach-generic/probe.c	2005-08-29 01:41:01.000000000 +0200
+++ 2.6.13-i386-genapic/arch/i386/mach-generic/probe.c	2005-09-05 14:31:31.000000000 +0200
@@ -3,6 +3,7 @@
  * 
  * Generic x86 APIC driver probe layer.
  */  
+#define APIC_DEFINITION 1
 #include <linux/config.h>
 #include <linux/threads.h>
 #include <linux/cpumask.h>
@@ -10,6 +11,7 @@
 #include <linux/kernel.h>
 #include <linux/ctype.h>
 #include <linux/init.h>
+#include <linux/module.h>
 #include <asm/fixmap.h>
 #include <asm/mpspec.h>
 #include <asm/apicdef.h>
@@ -21,6 +23,7 @@ extern struct genapic apic_es7000;
 extern struct genapic apic_default;
 
 struct genapic *genapic = &apic_default;
+EXPORT_SYMBOL(genapic);
 
 struct genapic *apic_probe[] __initdata = { 
 	&apic_summit,

Re: [PATCH] re-export genapic on i386

[Christoph Hellwig]

On Thu, Sep 08, 2005 at 05:47:34PM +0200, Jan Beulich wrote:
> (Note: Patch also attached because the inline version is certain to get
> line wrapped.)
> 
> A change not too long ago made i386's genapic symbol no longer be
> exported,
> and thus certain low-level functions no longer be usable. Since
> close-to-
> the-hardware code may still be modular, this rectifies the situation.

Again, what code would use it, why and why can't it use a proper accessor.
And a shitty thousands of lines out ot tree debugger ported from Novell's
legacy OS is not the answer, btw.

Re: [PATCH] re-export genapic on i386

[Andi Kleen]

Christoph Hellwig <hch@infradead.org> writes:

> On Thu, Sep 08, 2005 at 05:47:34PM +0200, Jan Beulich wrote:
> > (Note: Patch also attached because the inline version is certain to get
> > line wrapped.)
> > 
> > A change not too long ago made i386's genapic symbol no longer be
> > exported,
> > and thus certain low-level functions no longer be usable. Since
> > close-to-
> > the-hardware code may still be modular, this rectifies the situation.
> 
> Again, what code would use it, why and why can't it use a proper accessor.
> And a shitty thousands of lines out ot tree debugger ported from Novell's
> legacy OS is not the answer, btw.

Why not?  Most debuggers will always be out of tree for political
reasons, and because of that the normal "every hook must 
have an in tree user" rule cannot be strictly applied to them.

It's also not reasonable to ask these people to always 
carry big patchkits around - after all they just want
to debug core kernel code, and it is very ugly to apply
a big patchkit just for that.

So as long as the hooks for external modular debuggers 
are reasonable and _GPL I think they should be merged.

-Andi

Re: [PATCH] re-export genapic on i386

[Zwane Mwaikambo]

On Thu, 8 Sep 2005, Jan Beulich wrote:

> (Note: Patch also attached because the inline version is certain to get
> line wrapped.)
> 
> A change not too long ago made i386's genapic symbol no longer be
> exported,
> and thus certain low-level functions no longer be usable. Since
> close-to-
> the-hardware code may still be modular, this rectifies the situation.
> 
> Signed-off-by: Jan Beulich <jbeulich@novell.com>

Since there are no in-kernel tree users of this, i suggest that you keep 
it as a seperate patch, and generally for all exports that you may require 
for your external work. Then when/if your work gets merged you can submit 
it.

Thanks,
	Zwane