Fwd: [ANNOUNCE][GIT PATCH] Kconfig.cpu cosmetics

Fwd: [ANNOUNCE][GIT PATCH] Kconfig.cpu cosmetics

[Oliver Pinter]

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

---------- Forwarded message ----------
From: Oliver Pinter <oliver.pntr@gmail.com>
Date: Jul 22, 2007 10:11 PM
Subject: [ANNOUNCE][GIT PATCH] Kconfig.cpu cosmetics
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: zippel@linux-m68k.org, sam@ravnborg.org


Hi all!

Here is one patch, Kconfig.cpu, this patch add the Pentium D processor
for help, because number of person has the question: I have Pentium D,
and which CPU chose  I.

 arch/i386/Kconfig.cpu |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)

Thanks
Oliver

[-- Attachment #2: kconfig_cpu_cosmetic.patch --]
[-- Type: text/x-patch, Size: 1583 bytes --]

commit 0cfc7eee2dfe08dc0c609b57ed7be54886bd8f0b
Author: Oliver Pinter <oliver.pntr@gmail.com>
Date:   Sun Jul 22 21:59:27 2007 +0200

    Kconfig.cpu cosmetics
    
    	Add Pentium D for Pentium 4 help
	Change the sort by timeline in cpu-types

	Signed-off-by: Oliver Pinter <oliver.pntr@gmail.com>

diff --git a/arch/i386/Kconfig.cpu b/arch/i386/Kconfig.cpu
index 11a24d5..ce95e50 100644
--- a/arch/i386/Kconfig.cpu
+++ b/arch/i386/Kconfig.cpu
@@ -104,6 +104,15 @@ config MPENTIUMM
 	  Select this for Intel Pentium M (not Pentium-4 M)
 	  notebook chips.
 
+config MPENTIUM4
+	bool "Pentium-4/Celeron(P4-based)/Pentium-4 M/older Xeon"
+	help
+	  Select this for Intel Pentium 4 chips.  This includes the
+	  Pentium 4, Pentium D, P4-based Celeron and Xeon, and
+	  Pentium-4 M (not Pentium M) chips.  This option enables compile
+	  flags optimized for the chip, uses the correct cache shift, and
+	  applies any applicable Pentium III optimizations.
+
 config MCORE2
 	bool "Core 2/newer Xeon"
 	help
@@ -111,15 +120,6 @@ config MCORE2
 	  CPUs. You can distinguish newer from older Xeons by the CPU family
 	  in /proc/cpuinfo. Newer ones have 6.
 
-config MPENTIUM4
-	bool "Pentium-4/Celeron(P4-based)/Pentium-4 M/older Xeon"
-	help
-	  Select this for Intel Pentium 4 chips.  This includes the
-	  Pentium 4, P4-based Celeron and Xeon, and Pentium-4 M
-	  (not Pentium M) chips.  This option enables compile flags
-	  optimized for the chip, uses the correct cache shift, and
-	  applies any applicable Pentium III optimizations.
-
 config MK6
 	bool "K6/K6-II/K6-III"
 	help

Re: Fwd: [ANNOUNCE][GIT PATCH] Kconfig.cpu cosmetics

[Jan Engelhardt]

On Jul 22 2007 22:16, Oliver Pinter wrote:
> Hi all!
>
> Here is one patch, Kconfig.cpu, this patch add the Pentium D processor
> for help, because number of person has the question: I have Pentium D,
> and which CPU chose  I.
>
> arch/i386/Kconfig.cpu |   18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)

But why move the config entry?



	Jan
-- 

Re: Fwd: [ANNOUNCE][GIT PATCH] Kconfig.cpu cosmetics

[Oliver Pinter]

On 7/22/07, Jan Engelhardt <jengelh@computergmbh.de> wrote:
>
> On Jul 22 2007 22:16, Oliver Pinter wrote:
> > Hi all!
> >
> > Here is one patch, Kconfig.cpu, this patch add the Pentium D processor
> > for help, because number of person has the question: I have Pentium D,
> > and which CPU chose  I.
> >
> > arch/i386/Kconfig.cpu |   18 +++++++++---------
> > 1 files changed, 9 insertions(+), 9 deletions(-)
>
> But why move the config entry?
>

I thinked, sorted the items by time-line:
the old sort im Kconfig is i386..Pentium{I,II,III}..Core2..Pentium4
and the time line is    93 .. 95-99 .. 2006 .. 2001

and the new sort is:
... Pentium4 .. Core2

as the CPU-s manufactured.


>
>
>         Jan
> --
>

Thanks
Oliver

Re: Fwd: [ANNOUNCE][GIT PATCH] Kconfig.cpu cosmetics

[Jan Engelhardt]

On Jul 22 2007 22:45, Oliver Pinter wrote:
>>
>> But why move the config entry?
>
> I thinked, sorted the items by time-line:
> the old sort im Kconfig is i386..Pentium{I,II,III}..Core2..Pentium4
> and the time line is    93 .. 95-99 .. 2006 .. 2001
>
> and the new sort is:
> ... Pentium4 .. Core2
>
> as the CPU-s manufactured.

Ah yes, good idea.

[ Then again, I could ask, why not sort in reverse so that for the most recent
CPU, you do not have to scroll down on an evergrowing list... ]


	Jan
-- 

Re: Fwd: [ANNOUNCE][GIT PATCH] Kconfig.cpu cosmetics

[Oliver Pinter]

the primary reason is add the Pentium D for help and the position
switch is secondary.

and the patch motivated to make by Tilman Schmidt's mail:
>More generally, what is the correct way of selecting the processor
>family option for a CPU whose name doesn't appear anywhere in the
>prompts or help texts in arch/i386/Kconfig.cpu? I guess there must
>be a way of deducing it from the content of /proc/cpuinfo, only I
>cannot figure out how.

when anybody not know where cpu own, that to be entitled to know, that
the cpu-s is sorted by time-line or likely I know this?

Re: Fwd: [ANNOUNCE][GIT PATCH] Kconfig.cpu cosmetics

[Andi Kleen]

"Oliver Pinter" <oliver.pntr@gmail.com> writes:
> 
> Here is one patch, Kconfig.cpu, this patch add the Pentium D processor
> for help, because number of person has the question: I have Pentium D,
> and which CPU chose  I.

Your patch does a lot more than that; please do only one thing per patch.
Also x86-64 probably should get it too.

-Andi

Re: Fwd: [ANNOUNCE][GIT PATCH] Kconfig.cpu cosmetics

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

On Sun, 22 Jul 2007 22:16:14 +0200, Oliver Pinter said:

> Here is one patch, Kconfig.cpu, this patch add the Pentium D processor
> for help, because number of person has the question: I have Pentium D,
> and which CPU chose  I.

Would it make sense to extend the help sections in arch/i386/Kconfig.cpu to
list the family/model numbers reported by /proc/cpuinfo?  There's a few cookie
crumbs in there about new/old Xeons, and that Via Nehemiah chips are 'model 9'.
Should that be extended to be more complete?

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: Fwd: [ANNOUNCE][GIT PATCH] Kconfig.cpu cosmetics

[Sam Ravnborg]

On Mon, Jul 23, 2007 at 08:56:30PM -0400, Valdis.Kletnieks@vt.edu wrote:
> On Sun, 22 Jul 2007 22:16:14 +0200, Oliver Pinter said:
> 
> > Here is one patch, Kconfig.cpu, this patch add the Pentium D processor
> > for help, because number of person has the question: I have Pentium D,
> > and which CPU chose  I.
> 
> Would it make sense to extend the help sections in arch/i386/Kconfig.cpu to
> list the family/model numbers reported by /proc/cpuinfo?  There's a few cookie
> crumbs in there about new/old Xeons, and that Via Nehemiah chips are 'model 9'.
> Should that be extended to be more complete?

That makes perfect sense to me.
I have sometimes wondered what processor I had in the list.

	Sam