From: Chen Pei <cp0613@linux.alibaba.com>
To: bot+bpf-ci@kernel.org, "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
"Björn Töpel" <bjorn@kernel.org>,
"Puranjay Mohan" <puranjay@kernel.org>,
"Pu Lehui" <pulehui@huawei.com>,
bpf@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 1/2] bpf, riscv: Add support for signed arena loads
Date: Wed, 19 Aug 2026 20:06:29 +0800 [thread overview]
Message-ID: <reply-bpf-ci-arena-ldsx-comment-20260819@linux.alibaba.com> (raw)
In-Reply-To: <f6d031ece454ad8a2a3e09bbdf48d9030c74cb6741f76aabf58bf7af1931abfd@mail.kernel.org>
Hi,
On 2026/8/19 17:37, bot+bpf-ci@kernel.org wrote:
> This isn't a bug, but would the comment fit the surrounding style
> better as an expression? The neighbouring case-group comments all
> spell the access out in pseudo-code form:
>
> /* LDX: dst = *(unsigned size *)(src + off) */
> /* LDSX: dst = *(signed size *)(src + off) */
> /* LDX | PROBE_MEM32: dst = *(unsigned size *)(src + RV_REG_ARENA + off) */
> /* ST | PROBE_MEM32: *(size *)(dst + RV_REG_ARENA + off) = imm */
> /* STX | PROBE_MEM32: *(size *)(dst + RV_REG_ARENA + off) = src */
>
> Something like this would match the pattern:
>
> /* LDX | PROBE_MEM32SX: dst = *(signed size *)(src + RV_REG_ARENA + off) */
Agreed, consistency with the neighbouring comments is more valuable
here. The pseudo-code form will be restored in v3.
Best regards,
Pei
next prev parent reply other threads:[~2026-08-19 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 8:53 [PATCH bpf-next v2 0/2] " Chen Pei
2026-08-19 8:53 ` [PATCH bpf-next v2 1/2] " Chen Pei
2026-08-19 9:37 ` bot+bpf-ci
2026-08-19 12:06 ` Chen Pei [this message]
2026-08-19 8:53 ` [PATCH bpf-next v2 2/2] selftests/bpf: Enable arena LDSX tests for riscv64 Chen Pei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=reply-bpf-ci-arena-ldsx-comment-20260819@linux.alibaba.com \
--to=cp0613@linux.alibaba.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=memxor@gmail.com \
--cc=pulehui@huawei.com \
--cc=puranjay@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®