From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: tiwai@suse.com, perex@perex.cz, hui.wang@canonical.com,
kai.vehmanen@linux.intel.com, mwolf@adiumentum.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] HDA controller PM and codec PM cleanups
Date: Wed, 28 Oct 2020 20:38:19 +0100 [thread overview]
Message-ID: <s5h1rhixhsk.wl-tiwai@suse.de> (raw)
In-Reply-To: <20201027130038.16463-1-kai.heng.feng@canonical.com>
On Tue, 27 Oct 2020 14:00:35 +0100,
Kai-Heng Feng wrote:
>
> While working on the issue "ALSA: hda: fix jack detection with Realtek
> codecs when in D3", I've found using pm_runtime_force_{suspend,resume}()
> have surprising behavior, specifically, pm_runtime_need_not_resume()
> uses pm_runtime_need_not_resume() to avoid calling resume callback, so
> jackpoll was used to really power up the codec.
>
> We can use direct-complete to do the keep the codec suspended throughout
> the system PM flow, namely, keep the codec suspended all the way, unless
> the codec needs to be woken up after resume.
>
> For HDA controller, PCI core may enable direct-complete for it if
> conditions are met. So make runtime and system PM distinctive to always
> apply correct wake up setting.
>
> At least point, hopefully all runtime PM issues are solved, let's enable
> runtime PM by default again.
>
> v3:
> - Drop "ALSA: hda: Stop mangling PCI IRQ"
>
> Kai-Heng Feng (3):
> ALSA: hda: Refactor codec PM to use direct-complete optimization
> ALSA: hda: Separate runtime and system suspend
> ALSA: hda: Reinstate runtime_allow() for all hda controllers
Now I applied all three patches.
Since it's a nice improvement, I'm going to push to 5.10.
thanks,
Takashi
prev parent reply other threads:[~2020-10-29 1:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 13:00 Kai-Heng Feng
2020-10-27 13:00 ` [PATCH v3 1/3] ALSA: hda: Refactor codec PM to use direct-complete optimization Kai-Heng Feng
2020-10-27 13:00 ` [PATCH v3 2/3] ALSA: hda: Separate runtime and system suspend Kai-Heng Feng
2020-10-27 13:00 ` [PATCH v3 3/3] ALSA: hda: Reinstate runtime_allow() for all hda controllers Kai-Heng Feng
2020-10-28 19:38 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1rhixhsk.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=hui.wang@canonical.com \
--cc=kai.heng.feng@canonical.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mwolf@adiumentum.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®