From: Takashi Iwai <tiwai@suse.de>
To: "Jia-Ju Bai" <baijiaju1990@gmail.com>
Cc: <T-Bone@parisc-linux.org>, <perex@perex.cz>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<linux-parisc@vger.kernel.org>
Subject: Re: [PATCH 1/2] sound: ad1889: Replace mdelay with usleep_range in snd_ad1889_init
Date: Mon, 09 Apr 2018 15:17:09 +0200 [thread overview]
Message-ID: <s5h1sfoh63u.wl-tiwai@suse.de> (raw)
In-Reply-To: <1523279000-23973-1-git-send-email-baijiaju1990@gmail.com>
On Mon, 09 Apr 2018 15:03:20 +0200,
Jia-Ju Bai wrote:
>
> snd_ad1889_init() is never called in atomic context.
>
> The call chain ending up at snd_ad1889_init() is:
> [1] snd_ad1889_init() <- snd_ad1889_create() <- snd_ad1889_probe()
>
> snd_ad1889_probe() is only set as ".probe" in struct pci_driver.
> This function is not called in atomic context.
>
> Despite never getting called from atomic context, snd_ad1889_init()
> calls mdelay for busy wait.
> This is not necessary and can be replaced with usleep_range to
> avoid busy waiting.
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Since it's no urgent fix, I'll postpone to 4.18.
thanks,
Takashi
prev parent reply other threads:[~2018-04-09 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 13:03 Jia-Ju Bai
2018-04-09 13:17 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1sfoh63u.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=T-Bone@parisc-linux.org \
--cc=alsa-devel@alsa-project.org \
--cc=baijiaju1990@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®