mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] sound: ad1889: Replace mdelay with usleep_range in snd_ad1889_init
@ 2018-04-09 13:03 Jia-Ju Bai
  2018-04-09 13:17 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Jia-Ju Bai @ 2018-04-09 13:03 UTC (permalink / raw)
  To: T-Bone, perex, tiwai; +Cc: linux-parisc, alsa-devel, linux-kernel, Jia-Ju Bai

snd_ad1889_init() is never called in atomic context.

The call chain ending up at snd_ad1889_init() is:
[1] snd_ad1889_init() <- snd_ad1889_create() <- snd_ad1889_probe()

snd_ad1889_probe() is only set as ".probe" in struct pci_driver.
This function is not called in atomic context.

Despite never getting called from atomic context, snd_ad1889_init()
calls mdelay for busy wait.
This is not necessary and can be replaced with usleep_range to
avoid busy waiting.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
 sound/pci/ad1889.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/ad1889.c b/sound/pci/ad1889.c
index 0bf2c04..d4965eb 100644
--- a/sound/pci/ad1889.c
+++ b/sound/pci/ad1889.c
@@ -872,7 +872,7 @@ struct snd_ad1889 {
 	ad1889_writew(chip, AD_DS_CCS, AD_DS_CCS_CLKEN); /* turn on clock */
 	ad1889_readw(chip, AD_DS_CCS);	/* flush posted write */
 
-	mdelay(10);
+	usleep_range(10000, 11000);
 
 	/* enable Master and Target abort interrupts */
 	ad1889_writel(chip, AD_DMA_DISR, AD_DMA_DISR_PMAE | AD_DMA_DISR_PTAE);
-- 
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2] sound: ad1889: Replace mdelay with usleep_range in snd_ad1889_init
  2018-04-09 13:03 [PATCH 1/2] sound: ad1889: Replace mdelay with usleep_range in snd_ad1889_init Jia-Ju Bai
@ 2018-04-09 13:17 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2018-04-09 13:17 UTC (permalink / raw)
  To: Jia-Ju Bai; +Cc: T-Bone, perex, alsa-devel, linux-kernel, linux-parisc

On Mon, 09 Apr 2018 15:03:20 +0200,
Jia-Ju Bai wrote:
> 
> snd_ad1889_init() is never called in atomic context.
> 
> The call chain ending up at snd_ad1889_init() is:
> [1] snd_ad1889_init() <- snd_ad1889_create() <- snd_ad1889_probe()
> 
> snd_ad1889_probe() is only set as ".probe" in struct pci_driver.
> This function is not called in atomic context.
> 
> Despite never getting called from atomic context, snd_ad1889_init()
> calls mdelay for busy wait.
> This is not necessary and can be replaced with usleep_range to
> avoid busy waiting.
> 
> This is found by a static analysis tool named DCNS written by myself.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>

Since it's no urgent fix, I'll postpone to 4.18.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-09 13:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-09 13:03 [PATCH 1/2] sound: ad1889: Replace mdelay with usleep_range in snd_ad1889_init Jia-Ju Bai
2018-04-09 13:17 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®