* [PATCH] asihpi: clean up a couple of build warnings
@ 2017-10-16 12:19 Colin King
2017-10-16 12:48 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-10-16 12:19 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, alsa-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable dpcm is never used and hence can be removed. Variable
runtime is being assigned but is never read, so the assignment
is redundant and can be removed. Cleans up two clang warnings:
Value stored to 'dpcm' is never read
Value stored to 'runtime' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/pci/asihpi/asihpi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/pci/asihpi/asihpi.c b/sound/pci/asihpi/asihpi.c
index 614322171c79..720361455c60 100644
--- a/sound/pci/asihpi/asihpi.c
+++ b/sound/pci/asihpi/asihpi.c
@@ -573,10 +573,8 @@ static void snd_card_asihpi_pcm_int_start(struct snd_pcm_substream *substream)
static void snd_card_asihpi_pcm_int_stop(struct snd_pcm_substream *substream)
{
- struct snd_card_asihpi_pcm *dpcm;
struct snd_card_asihpi *card;
- dpcm = (struct snd_card_asihpi_pcm *)substream->runtime->private_data;
card = snd_pcm_substream_chip(substream);
hpi_handle_error(hpi_adapter_set_property(card->hpi->adapter->index,
@@ -863,7 +861,6 @@ static void snd_card_asihpi_timer_function(struct timer_list *t)
snd_pcm_group_for_each_entry(s, substream) {
struct snd_card_asihpi_pcm *ds = s->runtime->private_data;
- runtime = s->runtime;
/* don't link Cap and Play */
if (substream->stream != s->stream)
--
2.14.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] asihpi: clean up a couple of build warnings
2017-10-16 12:19 [PATCH] asihpi: clean up a couple of build warnings Colin King
@ 2017-10-16 12:48 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2017-10-16 12:48 UTC (permalink / raw)
To: Colin King; +Cc: alsa-devel, Jaroslav Kysela, kernel-janitors, linux-kernel
On Mon, 16 Oct 2017 14:19:21 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable dpcm is never used and hence can be removed. Variable
> runtime is being assigned but is never read, so the assignment
> is redundant and can be removed. Cleans up two clang warnings:
>
> Value stored to 'dpcm' is never read
> Value stored to 'runtime' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied (with the subject fix) now, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-16 12:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-16 12:19 [PATCH] asihpi: clean up a couple of build warnings Colin King
2017-10-16 12:48 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®