mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Arseniy Lartsev <ars3n@yandex.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: Wrong bitrate when capturing sound from Creative webcam
Date: Tue, 02 Mar 2010 11:31:53 +0100	[thread overview]
Message-ID: <s5h3a0jui92.wl%tiwai@suse.de> (raw)
In-Reply-To: <201002242018.45592.ars3n@yandex.ru>

At Wed, 24 Feb 2010 20:18:38 +0300,
Arseniy Lartsev wrote:
> 
> Hello,
> 
> I've got an USB webcam (Creative VF0470 Live Cam Notebook). The problem
> is that sound from it's microphone is captured with wrong bitrate.
> Apparently it reports 16000 Hz while it should actually be 8000 (so
> the sound is 2x faster).
> 
> The following patch works for me:
> --- linux-2.6.33-rc8/sound/usb/usbaudio.c
> +++ linux-2.6.33-rc8-new/sound/usb/usbaudio.c
> @@ -2513,6 +2513,8 @@ static int parse_audio_format_rates(stru
>  			     chip->usb_id == USB_ID(0x0d8c, 0x0102)) &&
>  			    fp->altsetting == 5 && fp->maxpacksize == 392)
>  				rate = 96000;
> +			if ((rate == 16000) && (chip->usb_id = USB_ID(0x041e, 0x4068)))
> +				rate = 8000;
>  			fp->rate_table[fp->nr_rates] = rate;
>  			if (!fp->rate_min || rate < fp->rate_min)
>  				fp->rate_min = rate;
> 
> I'm not sure if this is correct, maybe there should be more conditions
> to identify this particular camera.

The change looks good to me.  Could you give your sign-off for merge,
preferably repost in a right patch style?


thanks,

Takashi

      reply	other threads:[~2010-03-02 10:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24 17:18 Arseniy Lartsev
2010-03-02 10:31 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h3a0jui92.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=ars3n@yandex.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®