From: Takashi Iwai <tiwai@suse.de>
To: "Matthias Kaehlcke" <mka@chromium.org>
Cc: "Julia Lawall" <Julia.Lawall@lip6.fr>,
"Jaroslav Kysela" <perex@perex.cz>,
"Sven Hahne" <hahne@zeitkunst.eu>, <alsa-devel@alsa-project.org>,
"Grant Grundler" <grundler@chromium.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda/ca0132: Remove double parentheses
Date: Mon, 20 Mar 2017 12:55:28 +0100 [thread overview]
Message-ID: <s5h4lyow4b3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170315224123.175587-1-mka@chromium.org>
On Wed, 15 Mar 2017 23:41:23 +0100,
Matthias Kaehlcke wrote:
>
> The extra pairs of parantheses are not needed and causes clang to
> generate warnings like this:
>
> sound/pci/hda/patch_ca0132.c:1171:14: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
> if ((buffer == NULL))
> ~~~~~~~^~~~~~~
> sound/pci/hda/patch_ca0132.c:1171:14: note: remove extraneous parentheses around the comparison to silence this warning
> if ((buffer == NULL))
> ~ ^ ~
> sound/pci/hda/patch_ca0132.c:1171:14: note: use '=' to turn this equality comparison into an assignment
> if ((buffer == NULL))
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Applied, thanks.
Takashi
prev parent reply other threads:[~2017-03-20 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 22:41 Matthias Kaehlcke
2017-03-20 11:55 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4lyow4b3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=grundler@chromium.org \
--cc=hahne@zeitkunst.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®