From: Takashi Iwai <tiwai@suse.de>
To: "Martin Kepplinger" <martink@posteo.de>
Cc: <david.henningsson@canonical.com>, <han.lu@intel.com>,
<libin.yang@intel.com>, <treding@nvidia.com>, <perex@perex.cz>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] [REGRESSION] [BISECTED] -rc1 breaks audio over HDMI for i915
Date: Tue, 09 Feb 2016 12:44:24 +0100 [thread overview]
Message-ID: <s5h4mdixg4n.wl-tiwai@suse.de> (raw)
In-Reply-To: <56B98888.5000702@posteo.de>
On Tue, 09 Feb 2016 07:34:48 +0100,
Martin Kepplinger wrote:
>
> The following change:
>
> 788d441 ALSA: hda - Use component ops for i915 HDMI/DP audio jack handling
>
> breaks audio over HDMI on my snd_hda_intel laptop. It is the first bad
> commit.
>
> This was merged for -rc1 and isn't fixed until now, so I got nervous.
> There are
> no errors in the log that stand out. I'm no sound or alsa developer, and
> just reverting it isn't easy since there is stuff depending on this.
>
> I'm happy to test possible fixes and hope v4.5 not to ship with such a big
> regression ;)
Could you give a bit more detail about your hardware? At best, give
alsa-info.sh output (run with --no-upload option). Also, give the
output of dmesg, too.
In addition, what shows /proc/asound/card*/eld#*.* files? Does any of
it show the proper connection state and ELD?
A simple revert of the commit is a patch like below. Does it make the
HDMI audio working again?
thanks,
Takashi
---
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -156,7 +156,7 @@ struct hdmi_spec {
bool i915_bound; /* was i915 bound in this driver? */
};
-#ifdef CONFIG_SND_HDA_I915
+#if 0
#define codec_has_acomp(codec) \
((codec)->bus->core.audio_component != NULL)
#else
next prev parent reply other threads:[~2016-02-09 11:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 6:34 Martin Kepplinger
2016-02-09 11:44 ` Takashi Iwai [this message]
2016-02-10 14:47 ` Yang, Libin
2016-02-10 17:21 ` Martin Kepplinger
2016-02-11 9:06 ` Takashi Iwai
2016-02-12 13:09 ` Martin Kepplinger
2016-02-12 13:49 ` Takashi Iwai
2016-02-12 15:54 ` Martin Kepplinger
2016-02-12 16:16 ` Takashi Iwai
2016-02-22 10:24 ` Martin Kepplinger
2016-02-22 10:34 ` Takashi Iwai
2016-02-22 14:02 ` Martin Kepplinger
2016-02-22 14:12 ` Takashi Iwai
2016-02-22 18:58 ` Martin Kepplinger
2016-02-22 19:10 ` Takashi Iwai
2016-02-22 21:37 ` Martin Kepplinger
2016-02-23 16:57 ` Takashi Iwai
2016-02-23 17:09 ` Martin Kepplinger
2016-02-23 17:14 ` [Intel-gfx] " Ville Syrjälä
2016-02-23 19:09 ` Martin Kepplinger
2016-02-24 7:51 ` Takashi Iwai
2016-02-24 9:13 ` Takashi Iwai
2016-02-24 12:18 ` Martin Kepplinger
2016-02-24 14:28 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4mdixg4n.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=han.lu@intel.com \
--cc=libin.yang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=perex@perex.cz \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®