mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Denis Efremov <yefremov.denis@gmail.com>
Cc: Bill Pemberton <wfp5p@virginia.edu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: ali5451: remove irq enabling in pointer callback
Date: Mon, 11 Feb 2013 17:06:32 +0100	[thread overview]
Message-ID: <s5h4nhiq1h3.wl%tiwai@suse.de> (raw)
In-Reply-To: <1360597788-25614-1-git-send-email-yefremov.denis@gmail.com>

At Mon, 11 Feb 2013 19:49:48 +0400,
Denis Efremov wrote:
> 
> snd_ali_pointer function is called with local
> interrupts disabled. However it seems very strange to
> reenable them in such way.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>

Thanks, applied now.


Takashi

> ---
>  sound/pci/ali5451/ali5451.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c
> index 136a393..e760af9 100644
> --- a/sound/pci/ali5451/ali5451.c
> +++ b/sound/pci/ali5451/ali5451.c
> @@ -1435,7 +1435,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream)
>  
>  	spin_lock(&codec->reg_lock);
>  	if (!pvoice->running) {
> -		spin_unlock_irq(&codec->reg_lock);
> +		spin_unlock(&codec->reg_lock);
>  		return 0;
>  	}
>  	outb(pvoice->number, ALI_REG(codec, ALI_GC_CIR));
> -- 
> 1.8.1.2
> 

      reply	other threads:[~2013-02-11 16:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-11 15:49 Denis Efremov
2013-02-11 16:06 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h4nhiq1h3.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wfp5p@virginia.edu \
    --cc=yefremov.denis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®