mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
	Roel Kluin <roel.kluin@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/10] oss: midi_synth: check get_user() return value
Date: Thu, 29 Jul 2010 12:31:32 +0200	[thread overview]
Message-ID: <s5h4ofitw8r.wl%tiwai@suse.de> (raw)
In-Reply-To: <1280335277-23435-1-git-send-email-segooon@gmail.com>

At Wed, 28 Jul 2010 20:41:17 +0400,
Kulikov Vasiliy wrote:
> 
> get_user() may fail, if so return -EFAULT.
> 
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>

Applied now.  Thanks.


Takashi


> ---
>  sound/oss/midi_synth.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/oss/midi_synth.c b/sound/oss/midi_synth.c
> index 3bc7104..3c09374 100644
> --- a/sound/oss/midi_synth.c
> +++ b/sound/oss/midi_synth.c
> @@ -523,7 +523,9 @@ midi_synth_load_patch(int dev, int format, const char __user *addr,
>  	{
>  		unsigned char   data;
>  
> -		get_user(*(unsigned char *) &data, (unsigned char __user *) &((addr)[hdr_size + i]));
> +		if (get_user(data,
> +		    (unsigned char __user *)(addr + hdr_size + i)))
> +			return -EFAULT;
>  
>  		eox_seen = (i > 0 && data & 0x80);	/* End of sysex */
>  
> -- 
> 1.7.0.4
> 

      reply	other threads:[~2010-07-29 10:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 16:41 Kulikov Vasiliy
2010-07-29 10:31 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h4ofitw8r.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=roel.kluin@gmail.com \
    --cc=segooon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®