mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: perex@perex.cz, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] ALSA: Fix synchronize_irq() bugs, redundancies
Date: Tue, 22 Apr 2008 12:55:56 +0200	[thread overview]
Message-ID: <s5h4p9ub1kz.wl%tiwai@suse.de> (raw)
In-Reply-To: <20080421233419.GA4923@havoc.gtf.org>

At Mon, 21 Apr 2008 19:34:19 -0400,
Jeff Garzik wrote:
> 
> free_irq() calls synchronize_irq() for you, so there is no need for
> drivers to manually do the same thing (again).  Thus, calls where
> sync-irq immediately precedes free-irq can be simplified.
> 
> However, during this audit several bugs were noticed, where free-irq is
> preceded by a "irq >= 0" check... but the sync-irq call is not covered
> by the same check.
> 
> So, where sync-irq could not be eliminated completely, the missing check
> was added.
> 
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

Thanks, I applied to ALSA tree now.


Takashi

      parent reply	other threads:[~2008-04-22 10:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-21 23:34 Jeff Garzik
2008-04-21 23:35 ` [PATCH 2/2] drivers/net: " Jeff Garzik
2008-04-22  1:04   ` David Dillow
2008-04-22 10:55 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h4p9ub1kz.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®