mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound/pci/rme9652/hdspm.c: stop inlining largish static functions
Date: Mon, 14 Apr 2008 12:28:27 +0200	[thread overview]
Message-ID: <s5h4pa4hgs4.wl%tiwai@suse.de> (raw)
In-Reply-To: <200804010436.48348.vda.linux@googlemail.com>

At Tue, 1 Apr 2008 04:36:48 +0200,
Denys Vlasenko wrote:
> 
> Hi Takashi,
> 
> Can you please take a look at this patch?
> 
> sound/pci/rme9652/hdspm.c has unusually large number
> of static inline functions - 22.
> 
> I looked through them and some of them seem to be too big
> to warrant inlining.
> 
> This patch removes "inline" from these static functions
> (regardless of number of callsites - gcc nowadays auto-inlines
> statics with one callsite).
> 
> Size difference on 32bit x86:
>    text    data     bss     dec     hex filename
>   20437    2160     516   23113    5a49 linux-2.6-ALLYES/sound/pci/rme9652/hdspm.o
>   18036    2160     516   20712    50e8 linux-2.6.inline-ALLYES/sound/pci/rme9652/hdspm.o
> 
> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
> --
> vda

Thanks for the patch.  I applied it to ALSA tree together with coding
style fixes.


Takashi

      reply	other threads:[~2008-04-14 10:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-01  2:36 Denys Vlasenko
2008-04-14 10:28 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h4pa4hgs4.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®