* [PATCH -next] ALSA: pci: echoaudio: remove set but not used variable 'chip'
@ 2020-01-08 12:58 YueHaibing
2020-01-08 14:07 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-01-08 12:58 UTC (permalink / raw)
To: perex, tiwai, rfontana, allison, hslester96, o-takashi, kjlu,
yuehaibing, tglx
Cc: alsa-devel, linux-kernel
sound/pci/echoaudio/echoaudio.c: In function snd_echo_mixer_info:
sound/pci/echoaudio/echoaudio.c:1233:20: warning: variable chip set but not used [-Wunused-but-set-variable]
sound/pci/echoaudio/echoaudio.c: In function 'snd_echo_vmixer_info':
sound/pci/echoaudio/echoaudio.c:1300:20: warning: variable 'chip' set but not used [-Wunused-but-set-variable]
commit e67c3f0fd44c ("ALSA: pci: echoaudio: remove usage
of dimen menber of elem_value structure") left behind this
unused variable.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
sound/pci/echoaudio/echoaudio.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index 07fe0b3..0941a7a 100644
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -1230,9 +1230,6 @@ static const struct snd_kcontrol_new snd_echo_intput_nominal_level = {
static int snd_echo_mixer_info(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_info *uinfo)
{
- struct echoaudio *chip;
-
- chip = snd_kcontrol_chip(kcontrol);
uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
uinfo->count = 1;
uinfo->value.integer.min = ECHOGAIN_MINOUT;
@@ -1300,9 +1297,6 @@ static struct snd_kcontrol_new snd_echo_monitor_mixer = {
static int snd_echo_vmixer_info(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_info *uinfo)
{
- struct echoaudio *chip;
-
- chip = snd_kcontrol_chip(kcontrol);
uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
uinfo->count = 1;
uinfo->value.integer.min = ECHOGAIN_MINOUT;
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ALSA: pci: echoaudio: remove set but not used variable 'chip'
2020-01-08 12:58 [PATCH -next] ALSA: pci: echoaudio: remove set but not used variable 'chip' YueHaibing
@ 2020-01-08 14:07 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2020-01-08 14:07 UTC (permalink / raw)
To: YueHaibing
Cc: perex, tiwai, rfontana, allison, hslester96, o-takashi, kjlu,
tglx, alsa-devel, linux-kernel
On Wed, 08 Jan 2020 13:58:03 +0100,
YueHaibing wrote:
>
> sound/pci/echoaudio/echoaudio.c: In function snd_echo_mixer_info:
> sound/pci/echoaudio/echoaudio.c:1233:20: warning: variable chip set but not used [-Wunused-but-set-variable]
> sound/pci/echoaudio/echoaudio.c: In function 'snd_echo_vmixer_info':
> sound/pci/echoaudio/echoaudio.c:1300:20: warning: variable 'chip' set but not used [-Wunused-but-set-variable]
>
> commit e67c3f0fd44c ("ALSA: pci: echoaudio: remove usage
> of dimen menber of elem_value structure") left behind this
> unused variable.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-08 14:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08 12:58 [PATCH -next] ALSA: pci: echoaudio: remove set but not used variable 'chip' YueHaibing
2020-01-08 14:07 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®