mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] sound updates #2 for 2.6.40
Date: Sat, 28 May 2011 08:23:52 +0200	[thread overview]
Message-ID: <s5h62ov1gxz.wl%tiwai@suse.de> (raw)
In-Reply-To: <BANLkTimvMKF-ULuk=B52hji3GSr=tXrWXw@mail.gmail.com>

At Fri, 27 May 2011 19:44:54 -0700,
Linus Torvalds wrote:
> 
> On Fri, May 27, 2011 at 7:41 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Looking at that diff, I found at least one bug:
> >
> > -       if (chip->driver_type != AZX_DRIVER_ATI &&
> > -           chip->driver_type != AZX_DRIVER_ATIHDMI)
> > +       if (chip->driver_caps & AZX_DCAPS_NO_TCSEL) {
> >
> > That's wrong. It should be
> >
> >        if (!(chip->driver_caps & AZX_DCAPS_NO_TCSEL)) {
> >
> > but I haven't checked if that fixes it for me yet.
> 
> Yup, that's it. Apparently if you don't clear the TCSEL bit, you get
> random static and repeated stuff.
> 
> And the reason the conversion was wrong is that the bit is not a
> "feature" bit, it's a "lack of feature" bit, but the conversion missed
> the negation.

My bad.  I concentrated on fixing AMD issues, and this was a part of
it.  Obviously I didn't test Intel boxes carefully enough.

Sorry for taking your time!


Takashi

      reply	other threads:[~2011-05-28  6:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-27  9:42 Takashi Iwai
2011-05-27 23:50 ` Linus Torvalds
2011-05-28  0:02   ` Linus Torvalds
2011-05-28  0:09     ` Linus Torvalds
2011-05-28  2:41       ` Linus Torvalds
2011-05-28  2:44         ` Linus Torvalds
2011-05-28  6:23           ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h62ov1gxz.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®