From: Takashi Iwai <tiwai@suse.de>
To: "Mike Frysinger" <vapier.adi@gmail.com>
Cc: tj@kernel.org, "Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: OSS sound core optionalization has __init/__exit mismatches
Date: Sat, 13 Sep 2008 17:19:01 +0200 [thread overview]
Message-ID: <s5h63p09iqi.wl%tiwai@suse.de> (raw)
In-Reply-To: <8bd0f97a0809120822n40c8f99k45bb91e670cca805@mail.gmail.com>
At Fri, 12 Sep 2008 11:22:21 -0400,
Mike Frysinger wrote:
>
> this commit:
> commit 1be95f401657e75984871c369d774d507e462939
> Author: Tejun Heo <tj@kernel.org>
> Date: Thu Aug 28 16:42:51 2008 +0200
> sound: make OSS sound core optional
>
> results in this failure:
> WARNING: vmlinux.o(.init.text+0xfbf0): Section mismatch in reference
> from the function _init_soundcore() to the function
> .exit.text:_cleanup_oss_soundcore()
> The function __init _init_soundcore() references
> a function __exit _cleanup_oss_soundcore().
> This is often seen when error handling in the init function
> uses functionality in the exit path.
> The fix is often to remove the __exit annotation of
> _cleanup_oss_soundcore() so it may be used outside an exit section.
>
> and can easily be seen in sound/sound_core.c:
> ...
> static int __init init_soundcore(void)
> {
> ...
> cleanup_oss_soundcore();
> ...
> }
> ...
> static void __exit cleanup_oss_soundcore(void)
> {
> ...
> }
> ...
> -mike
Thanks for reporting. It was already fixed on my sound-2.6.git.
Takashi
prev parent reply other threads:[~2008-09-13 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 15:22 Mike Frysinger
2008-09-13 15:19 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h63p09iqi.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®