From: Takashi Iwai <tiwai@suse.de>
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: adrien.crivelli@gmail.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, perex@perex.cz, tiwai@suse.com
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches
Date: Tue, 25 Aug 2020 10:00:31 +0200 [thread overview]
Message-ID: <s5h7dtn6tpc.wl-tiwai@suse.de> (raw)
In-Reply-To: <30693624-744d-6971-1dc8-8ffe4df6082c@gmail.com>
On Mon, 24 Aug 2020 14:31:17 +0200,
Alex Dewar wrote:
>
> My mistake -- I didn't read your changelog properly. Sorry!
Would you resubmit the corrected fix patch?
Also, better to indicate the device id number in the patch
description. It's confusing which entry you've corrected
intentionally for what, and documenting it would help understanding
it.
thanks,
Takashi
>
> On 24/08/2020 13:30, Alex Dewar wrote:
> > There's a mistake in this. The ID numbers are the wrong way round.
> >
> > Alex
>
next prev parent reply other threads:[~2020-08-25 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 12:30 Alex Dewar
2020-08-24 12:31 ` Alex Dewar
2020-08-25 8:00 ` Takashi Iwai [this message]
[not found] ` <CACjDtnKEGf_z3_wvP5Y_55UgqdPuNRWtONefBXtg0tq7f=ArxQ@mail.gmail.com>
2020-08-25 15:03 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2020-08-24 12:15 Adrien Crivelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7dtn6tpc.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=adrien.crivelli@gmail.com \
--cc=alex.dewar90@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®