From: Takashi Iwai <tiwai@suse.de>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] ASoC: cx2072x: remove set but not used variable 'is_right_j '
Date: Mon, 27 May 2019 09:38:05 +0200 [thread overview]
Message-ID: <s5h7eac9wki.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190525123204.16148-1-yuehaibing@huawei.com>
On Sat, 25 May 2019 14:32:04 +0200,
YueHaibing wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> sound/soc/codecs/cx2072x.c: In function cx2072x_config_i2spcm:
> sound/soc/codecs/cx2072x.c:679:6: warning: variable is_right_j set but not used [-Wunused-but-set-variable]
>
> It's never used and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
> ---
> sound/soc/codecs/cx2072x.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/codecs/cx2072x.c b/sound/soc/codecs/cx2072x.c
> index 23d2b25fe04c..a066ef83de1a 100644
> --- a/sound/soc/codecs/cx2072x.c
> +++ b/sound/soc/codecs/cx2072x.c
> @@ -676,7 +676,6 @@ static int cx2072x_config_i2spcm(struct cx2072x_priv *cx2072x)
> unsigned int bclk_rate = 0;
> int is_i2s = 0;
> int has_one_bit_delay = 0;
> - int is_right_j = 0;
> int is_frame_inv = 0;
> int is_bclk_inv = 0;
> int pulse_len = 1;
> @@ -740,7 +739,6 @@ static int cx2072x_config_i2spcm(struct cx2072x_priv *cx2072x)
>
> case SND_SOC_DAIFMT_RIGHT_J:
> is_i2s = 1;
> - is_right_j = 1;
> pulse_len = frame_len / 2;
> break;
>
> --
> 2.17.1
>
>
>
next prev parent reply other threads:[~2019-05-27 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 12:32 YueHaibing
2019-05-27 7:38 ` Takashi Iwai [this message]
2019-06-04 14:59 ` Applied "ASoC: cx2072x: remove set but not used variable 'is_right_j '" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7eac9wki.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®